From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id EDC0520EC8A
	for <inbox@lore.proxmox.com>; Mon, 29 Apr 2024 15:03:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id AFB0B1185B;
	Mon, 29 Apr 2024 15:03:47 +0200 (CEST)
Message-ID: <071338ce-d5be-4bc8-92b0-9c33b78f3e62@proxmox.com>
Date: Mon, 29 Apr 2024 15:03:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20240429125300.86575-1-f.ebner@proxmox.com>
Content-Language: en-US
In-Reply-To: <20240429125300.86575-1-f.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.066 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu] PVE backup: improve error when
 copy-before-write fails for fleecing
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 29.04.24 um 14:53 schrieb Fiona Ebner:
> With fleecing, failure for copy-before-write does not fail the guest
> write, but only sets the snapshot error that is associated to the
> copy-before-write filter, making further requests to the snapshot
> access fail with EACCES, which then also fails the job. But that error
> code is not the root cause of why the backup failed, so bubble up the
> original snapshot error instead.
> 
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> Tested-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> 
> Should have a "fixes #5409:" prefix when applied in the parent git

It seems the user does not run into the timeout, but some other issue
https://bugzilla.proxmox.com/show_bug.cgi?id=5409#c15
So while we will better see what the issue is, it's not a fix after all.

> module. Please consider applying this after the update to QEMU 9.0.0.
> Otherwise, I'll have to adapt and re-send that.
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel