From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2AC8468EC4 for ; Mon, 22 Feb 2021 14:40:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F675A05D for ; Mon, 22 Feb 2021 14:40:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B19A9A050 for ; Mon, 22 Feb 2021 14:40:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 74EFE41BA4 for ; Mon, 22 Feb 2021 14:40:11 +0100 (CET) Message-ID: <06c826b2-3524-86ed-a4cd-c8bcfbb9b95b@proxmox.com> Date: Mon, 22 Feb 2021 14:40:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20210222101626.19240-1-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210222101626.19240-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 1/2] ui: FirewallRules: make columns flexible X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 13:40:42 -0000 On 22.02.21 11:16, Aaron Lauterer wrote: > Changing the width definitions to use flex will make better use on > larger monitors. Changing the `width` parameter to `minWidth` ensures > that on smaller screens it is still usable, though some horizontal > scrolling might be necessary. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/grid/FirewallRules.js | 38 ++++++++++++++++++++---------- > 1 file changed, 25 insertions(+), 13 deletions(-) > > applied, thanks! Followed up with some further changes as I remembered a discussion I had with Dietmar about to many flex in columns (see commit message for details)