From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 614831FF16E
for <inbox@lore.proxmox.com>; Tue, 29 Oct 2024 14:59:01 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4DEFF3753D;
Tue, 29 Oct 2024 14:59:03 +0100 (CET)
Message-ID: <066f358b-6198-4a1d-95ad-fb1fe774a702@proxmox.com>
Date: Tue, 29 Oct 2024 14:58:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
References: <20241025111304.99680-1-f.weber@proxmox.com>
<20241025111304.99680-2-f.weber@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <20241025111304.99680-2-f.weber@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.039 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [rbdplugin.pm, proxmox.com, plugin.pm]
Subject: Re: [pve-devel] [PATCH storage 1/2] fix #5779: rbd: allow to pass
custom krbd map options
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Does what it claims to do, setting the parameter `rxbounce` when mapping
the RBD disk.
Therefore:
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
But one question inline...
On 2024-10-25 13:13, Friedrich Weber wrote:
> When KRBD is enabled for an RBD storage, the storage plugin calls out
> to `rbd map` to map an RBD image as a block device on the host.
> Sometimes it might be necessary to pass custom options to `rbd map`.
> For instance, in some setups with Windows VMs, KRBD logs `bad
> crc/signature` and VMs performance is degraded unless the `rxbounce`
> option is enabled, as reported in the forum [1].
>
> To allow users to specify custom options for KRBD, introduce a
> corresponding `krbd-map-options` property to the RBD plugin. The
> property is designed to only accept a supported set of map options.
> For now, this is only the `rxbounce` map option, but the supported set
> can be extended in the future.
>
> The reasoning for constraining the supported set of map options
> instead of allowing to pass a free-form option string is as follows:
> If `rxbounce` turns out to be a sensible default, accepting a
> free-form option string now will make it hard to switch over the
> default to `rxbounce` while still allowing users to disable `rxbounce`
> if needed. This would require scanning the free-form string for a
> `norxbounce` or similar, which is cumbersome.
>
> If users need to set a map option that `krbd-map-options` does not
> support (yet), they can alternatively set the RBD config option
> `rbd_default_map_options` [2].
>
> [1] https://forum.proxmox.com/threads/155741/
> [2] https://github.com/ceph/ceph/blob/b2a4bd840/src/common/options/rbd.yaml.in#L507
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> src/PVE/Storage/Plugin.pm | 10 ++++++++++
> src/PVE/Storage/RBDPlugin.pm | 14 +++++++++++++-
> 2 files changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 8cc693c..02be257 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -394,6 +394,16 @@ sub verify_dir_override {
> die "invalid override '$value'\n";
> }
>
> +PVE::JSONSchema::register_format('pve-storage-krbd-map-option', \&verify_krbd_map_option);
> +sub verify_krbd_map_option {
> + my ($option, $noerr) = @_;
> +
> + return $option if $option eq 'rxbounce';
> +
> + return undef if $noerr;
> + die "invalid krbd map option '$option'\n";
> +}
> +
Why do you place this RBD specific option in the general `Plugin.pm` and
not into the `RBDPlugin.pm`?
A quick test of mine where I places this in the `RBDPlugin.pm` before
the properties sub seemed to have worked fine.
> sub private {
> return $defaultData;
> }
> diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
> index f45ad3f..8110cff 100644
> --- a/src/PVE/Storage/RBDPlugin.pm
> +++ b/src/PVE/Storage/RBDPlugin.pm
> @@ -394,6 +394,12 @@ sub properties {
> description => "Client keyring contents (for external clusters).",
> type => 'string',
> },
> + 'krbd-map-options' => {
> + description => "Additional map options (only for krbd). Supported:"
> + ." rxbounce.",
> + type => 'string',
> + format => 'pve-storage-krbd-map-option-list',
> + },
> };
> }
>
> @@ -410,6 +416,7 @@ sub options {
> krbd => { optional => 1 },
> keyring => { optional => 1 },
> bwlimit => { optional => 1 },
> + 'krbd-map-options' => { optional => 1 },
> };
> }
>
> @@ -726,7 +733,12 @@ sub map_volume {
> # features can only be enabled/disabled for image, not for snapshot!
> $krbd_feature_update->($scfg, $storeid, $img_name);
>
> - my $cmd = $rbd_cmd->($scfg, $storeid, 'map', $name);
> + my @additional_options = ();
> + if ($scfg->{'krbd-map-options'}) {
> + @additional_options = ('--options', $scfg->{'krbd-map-options'});
> + }
> +
> + my $cmd = $rbd_cmd->($scfg, $storeid, 'map', $name, @additional_options);
> run_rbd_command($cmd, errmsg => "can't map rbd volume $name");
>
> return $kerneldev;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel