From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DCBA56AF41 for ; Thu, 17 Mar 2022 13:34:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D3C673E9C for ; Thu, 17 Mar 2022 13:33:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5A5263E8B for ; Thu, 17 Mar 2022 13:33:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2E30F46EB4 for ; Thu, 17 Mar 2022 13:33:31 +0100 (CET) Message-ID: <05e4f2eb-c212-4cc8-c2d3-4ef651d999bb@proxmox.com> Date: Thu, 17 Mar 2022 13:33:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Daniel Tschlatscher References: <20220317121650.4070215-1-d.tschlatscher@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220317121650.4070215-1-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [status.pm] Subject: Re: [pve-devel] [PATCH v2 container] fix #3927: Containers that are already stopped now return 0, like VMs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 12:34:01 -0000 On 17.03.22 13:16, Daniel Tschlatscher wrote: > Signed-off-by: Daniel Tschlatscher > --- > Fixed indentation and trailing whitespace > src/PVE/API2/LXC/Status.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm > index f7e3128..d4e0b66 100644 > --- a/src/PVE/API2/LXC/Status.pm > +++ b/src/PVE/API2/LXC/Status.pm > @@ -238,7 +238,11 @@ __PACKAGE__->register_method({ > raise_param_exc({ skiplock => "Only root may use this option." }) > if $skiplock && $authuser ne 'root@pam'; > > - die "CT $vmid not running\n" if !PVE::LXC::check_running($vmid); > + # Containers that are already stopped should exit with code 0, like VMs do > + if (!PVE::LXC::check_running($vmid)) { > + print "CT $vmid not running\n"; > + exit 0; for the record (just talked off-list): this is the API code path that the CLI handler only reuses, and while for the CLI use case a print STDOUT + exit can be OK, it means a broken connection and existing an API worker process potentially impacting other API requests that said worker process could handle concurrently. FYI, qemu-server does actually the same (die "already running") but there it happens inside the worker there, which for the CLI means basically above behavior while the API gets a error task result. > + } > > if (PVE::HA::Config::vm_is_ha_managed($vmid) && $rpcenv->{type} ne 'ha') { >