From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 32C011FF17E for ; Thu, 16 Oct 2025 13:38:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AEA891161D; Thu, 16 Oct 2025 13:39:09 +0200 (CEST) Message-ID: <05c78707-8733-495d-a874-6108975f5bb6@proxmox.com> Date: Thu, 16 Oct 2025 13:39:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Daniel Kral References: <20250930142021.366529-1-d.kral@proxmox.com> <20250930142021.366529-8-d.kral@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250930142021.366529-8-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760614743837 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [manager.pm] Subject: Re: [pve-devel] [PATCH ha-manager 4/9] manager: remove redundant add_service_usage_to_node from next_state_started X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 30.09.25 um 4:20 PM schrieb Daniel Kral: > Since 5c2eef4b ("account service to source and target during move") a > moving HA resource's load is accounted for on the source and target > nodes. > > A HA resource in the 'started' state, which is not configured otherwise > or has no pending CRM commands left to process, actively checks whether > there is "better" node placement by querying select_service_node(...). > When a better node is found, the HA resource will be migrated or > relocated to the found node depending on their type. > > The add_service_usage_to_node(...) is redundant at this point as the > subsequent call to change_service_state(...) to either the 'migrate' or > 'relocate' state will call recompute_online_node_usage(...) and make > the changes to $online_node_usage be discarded immediately. Same here, if this is still covered by change_service_state() with more granular operations at the end of the series please mention that here and consider it: > Signed-off-by: Daniel Kral Reviewed-by: Fiona Ebner > --- > src/PVE/HA/Manager.pm | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm > index 6afc9250..468e41eb 100644 > --- a/src/PVE/HA/Manager.pm > +++ b/src/PVE/HA/Manager.pm > @@ -1194,9 +1194,6 @@ sub next_state_started { > ); > > if ($node && ($sd->{node} ne $node)) { > - $self->{online_node_usage}->add_service_usage_to_node($node, $sid, $sd->{node}); > - $self->{online_node_usage}->add_service_node($sid, $node); > - > if (defined(my $fallback = $sd->{maintenance_node})) { > if ($node eq $fallback) { > $haenv->log( _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel