From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CCBFE9890C for ; Fri, 12 May 2023 11:58:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AAE6B2B10D for ; Fri, 12 May 2023 11:58:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 May 2023 11:58:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E3856420BC for ; Fri, 12 May 2023 11:58:24 +0200 (CEST) Message-ID: <0552f5c8-fa63-7ae0-befd-0d727767b3c0@proxmox.com> Date: Fri, 12 May 2023 11:58:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Wolfgang Bumiller Cc: pve-devel@lists.proxmox.com References: <20230502150536.173929-1-f.weber@proxmox.com> <20230512091951.gmiysuv6bdm2wpbp@fwblub> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20230512091951.gmiysuv6bdm2wpbp@fwblub> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.684 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.124 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 container] lxc start: warn in case of conflicting lxc.idmap entries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2023 09:58:55 -0000 Thanks for the review! On 12/05/2023 11:19, Wolfgang Bumiller wrote: >> So to report *all* conflicts, we'd need an algorithm that keeps track >> of all currently active intervals while iterating. I'm open for > > ^ Only the end really. I think you're right, we only need to track the endpoints of all currently active intervals. >> implementing this, but in my opinion, the algorithm in this patch is >> good enough to be helpful, and since it's nicer to keep things simple, >> I'd keep that one. What do you think? > > Yeah, given that we don't know the user's actual intention anyway, this > really doesn't matter and the current implementation is fine. Sounds good! >> +sub validate_id_maps { >> + my ($id_map) = @_; >> + >> + # $mappings->{$type}{$side} = [ { line => $line, start => $start, count => $count }, ... ] > > ^ we always use arrows there: {$type}->{$side} > > Basically, we always strictly separate with arrows. Old code might have > some mixed prefix-derefs, but there shouldn't be any code using > consecutive `{x}{y}` style dereferencing. Makes sense. I'll send a v3 to rewrite all {x}{y} to {x}->{y}.