From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AB9479366A for ; Mon, 20 Feb 2023 13:38:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8261826B5A for ; Mon, 20 Feb 2023 13:37:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 20 Feb 2023 13:37:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B6F3C47CF1 for ; Mon, 20 Feb 2023 13:37:38 +0100 (CET) Message-ID: <05242771-1c87-2f30-7fb1-f06092d6a813@proxmox.com> Date: Mon, 20 Feb 2023 13:37:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: de-AT, en-GB To: Proxmox VE development discussion , Wolfgang Bumiller , Christoph Heiss References: <20230215140245.496507-1-c.heiss@proxmox.com> <20230215140245.496507-4-c.heiss@proxmox.com> <20230217145103.sl2bgaoq5jtuskp6@fwblub> <76af9067-9481-975f-00ac-c8b5602036d6@proxmox.com> <20230220115155.q2mceyrpa7qubdjp@maui.proxmox.com> <20230220123306.nsghztog6ec4mw4p@casey.proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230220123306.nsghztog6ec4mw4p@casey.proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2023 12:38:09 -0000 Am 20/02/2023 um 13:33 schrieb Wolfgang Bumiller: >>> I assumed that, that's why I asked if keeping it that way would help = to reuse some >>> code infra; not sure about how useful it is to keep it for API consum= ers to keep it >>> the same as in a quite different API end point, >> There really is no code-reuse between those two endpoints, so it made >> sense to me too to rename it. > It's more about possible code reuse in front-ends rather than in the > backend though, where a set of common options with common code to > fill/read/... them can definitely be a thing =F0=9F=98=89 fwiw, it won't matter for any of our front ends either, the CT and VM net= work API is way to different to share full (edit) panels. But, for automation tooling that talks with the API it might be quite rel= evant. >=20 >>> but I see where you come from and don't >>> insist for going with snake-case, so if you think using the same styl= e here has benefits. >>> we can ignore the guidance that new params should always use kebab-ca= se. >> .. but I will rename it back to snake_case for v3, since that seems to= >> be consensus here? > Given Thomas' plan to rename stuff in the future, I'd say yes, for now.= fine by me, snake_case it is for now, for this specific option.