From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 36F0D69C97 for ; Fri, 25 Mar 2022 09:51:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F6E9378CD for ; Fri, 25 Mar 2022 09:51:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B8B16378C2 for ; Fri, 25 Mar 2022 09:51:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8B67E46F32 for ; Fri, 25 Mar 2022 09:51:53 +0100 (CET) Message-ID: <04f521d1-7cc0-f47e-bdd8-b0346904ffa9@proxmox.com> Date: Fri, 25 Mar 2022 09:51:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Daniel Tschlatscher References: <20220325083437.498400-1-d.tschlatscher@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220325083437.498400-1-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-qemu v2] fix: 3865: backup restore human readable output X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 08:51:54 -0000 On 25.03.22 09:34, Daniel Tschlatscher wrote: > The backup restore dialogue now displays size information and duration in a format more easily understandable for humans. The output was adapated to match the output of the backup create dialogue where possible. > Added 2 helper methods for displaying bytes and time in human readable format. > > Signed-off-by: Daniel Tschlatscher > --- > > Changes to v1: Fixed the indentation (there were a few rogue tab stops) and fixed a typo in the commit message for such changes I'd wait out for an actual review to avoid noise, e.g., like I made on 5 minutes ago ;-P Also, this depends on the type of work, but for new functionality in repos where we use debian/patches for applying downstream work it can be worth to send out the (initial) revisions as "inner" patch, i.e., like they'd come directly from the upstream patched repo, that makes review easier. A patch-patch can then be either sent once all is ready and reviewed OK, or also done by the applier (depends on the appliers' preferences, I often don't mind doing so)