From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E2AB2C0B53 for ; Fri, 12 Jan 2024 10:31:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BCE1C1F1BC for ; Fri, 12 Jan 2024 10:30:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Jan 2024 10:30:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E2FFD4536F for ; Fri, 12 Jan 2024 10:30:36 +0100 (CET) Message-ID: <04539764-6328-40bd-b4bf-d5867eafd735@proxmox.com> Date: Fri, 12 Jan 2024 10:30:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Friedrich Weber , Proxmox VE development discussion References: <20240111165826.804669-1-f.weber@proxmox.com> From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage] lvm: avoid warning due to human-readable text in vgs output X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2024 09:31:07 -0000 Am 12.01.24 um 10:09 schrieb Friedrich Weber: > On 12/01/2024 09:57, Fiona Ebner wrote: >> Am 11.01.24 um 17:58 schrieb Friedrich Weber: >>> >>> [1] https://sourceware.org/git/?p=lvm2.git;a=blob;f=lib/format_text/archive.c;h=5acf0c04a;hb=38e0c7a1#l222 >>> >> >>> 222 log_print_unless_silent("Consider pruning %s VG archive with more then %u MiB in %u files (see archiving settings in lvm.conf).", >>> 223 vgname, (unsigned)sum, archives_size); >> >> Can we pass a silent flag when invoking the command instead? > > Good point. A quick test shows passing `-q` does not suppress the > message, but passing `-qq` does. Documentation on `-qq` [1]: > >> -q|--quiet ... >> Suppress output and log messages. Overrides --debug and --verbose. > Repeat once to also suppress any prompts with answer 'no'. > That actually sounds like a single -q should be enough, but oh well... > Not sure if automatically answering prompts with 'no' might cause > problems -- I don't think I've ever seen a yes/no prompt by `vgs` > though. What do you think? > Since it's only for listing images, I'd be rather surprised by such a prompt. And I really hope 'no' would then be the safe option ;)