From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4478169F1B for ; Thu, 25 Feb 2021 12:17:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A55A33956 for ; Thu, 25 Feb 2021 12:17:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BA9EC33949 for ; Thu, 25 Feb 2021 12:17:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 838034173C for ; Thu, 25 Feb 2021 12:17:47 +0100 (CET) Message-ID: <0415d711-67a9-9589-ce1c-2fcb6c9b2566@proxmox.com> Date: Thu, 25 Feb 2021 12:17:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Oguz Bektas , Proxmox VE development discussion References: <20210225101650.272444-1-o.bektas@proxmox.com> <5429d2b2-a0a8-f9f7-6d2a-57f59408efdc@proxmox.com> <20210225110106.GB11907@gaia.proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210225110106.GB11907@gaia.proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container] mention file path for ct debug log X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2021 11:17:48 -0000 On 25.02.21 12:01, Oguz Bektas wrote: > On Thu, Feb 25, 2021 at 11:58:53AM +0100, Thomas Lamprecht wrote: >> On 25.02.21 11:16, Oguz Bektas wrote: >>> Signed-off-by: Oguz Bektas >>> --- >>> src/PVE/LXC.pm | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm >>> index bae236b..db9a2ee 100644 >>> --- a/src/PVE/LXC.pm >>> +++ b/src/PVE/LXC.pm >>> @@ -2306,7 +2306,10 @@ sub vm_start { >>> monitor_start($monitor_socket, $vmid) if defined($monitor_socket); >>> >>> # if debug is requested, print the log it also when the start succeeded >>> - print_ct_stderr_log($vmid) if $is_debug; >>> + if ($is_debug) { >>> + print_ct_stderr_log($vmid); >>> + print "debug log saved in: /run/pve/ct-$vmid.stderr\n"; >> >> why though? all of that file is printed so what use is it to see the >> path (with just the same content one just gets printed). > > hmm i was thinking it'd be easier to attach on the forum threads. > how so? It would only be easier to use that if they had desktop environment installed and currently use that so that they could prose to the file, but actually... >> >> Also it's not really saved, this is just in memory. I'd not print that... > > then maybe we can just save it somewhere and print that? ... it's already saved in the task log which they just can copy from the webinterface (and naturally task log file too), seems quite easy to me? > >> >>> + } >>> }; >>> if (my $err = $@) { >>> unlink $skiplock_flag_fn; >>> >>