From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D57197367C for ; Thu, 7 Oct 2021 15:00:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC2821A74D for ; Thu, 7 Oct 2021 14:59:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 553B71A73E for ; Thu, 7 Oct 2021 14:59:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 223AE4586F for ; Thu, 7 Oct 2021 14:59:48 +0200 (CEST) Message-ID: <03fd37b8-3be2-834a-d0d8-57c4edef2233@proxmox.com> Date: Thu, 7 Oct 2021 14:58:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US From: Thomas Lamprecht To: Proxmox VE development discussion , Lorenz Stechauner Reply-To: Proxmox VE development discussion References: <20211007124253.3484118-1-l.stechauner@proxmox.com> <5eb47579-e1b9-49b4-ab2d-26fe88445e3f@proxmox.com> In-Reply-To: <5eb47579-e1b9-49b4-ab2d-26fe88445e3f@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.192 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.964 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2021 13:00:18 -0000 On 07.10.21 14:55, Thomas Lamprecht wrote: > there are a few ways to implement that and the commit message gives zero reasoning > about the chosen one, I do not really like that... > > why not allowing one to enter it as suffix in the host field like we do in PBS for > the remotes. > > An extra field is always distracting for newer users as it's yet another choice one can possible make, argh, hit send to early... but anyhow, its something that most users won't care, so it should be in the advanced or (preferred) extracted from the hosts, we already have a vtype for host-with-port (its not called that but not too hard to find)