From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 67DE01FF16F for <inbox@lore.proxmox.com>; Thu, 13 Feb 2025 11:11:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E21B2F94C; Thu, 13 Feb 2025 11:11:27 +0100 (CET) Message-ID: <03866a14-f5a5-4233-94b0-203ea1e7515e@proxmox.com> Date: Thu, 13 Feb 2025 11:10:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Daniel Herzig <d.herzig@proxmox.com> References: <20250210120722.163622-1-d.herzig@proxmox.com> <20250210120722.163622-2-d.herzig@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20250210120722.163622-2-d.herzig@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH 1/8 container] cloudinit: introduce config parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 10.02.25 um 13:07 schrieb Daniel Herzig: > From: Leo Nunner <l.nunner@proxmox.com> > > Introduce configuration parameters for cloud-init. Like with VMs, it's > possible to specify: > - user > - password > - ssh keys > - enable/disable updates on first boot > > It's also possible to pass through custom config files for the user and > vendor settings. We don't allow configuring the network through > cloud-init, since it will clash with whatever configuration we already > did for the container. Unfortunately, Leo didn't write why configuring 'meta' for cicustom is not allowed... > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm > index 5cc37f7..e3ed93b 100644 > --- a/src/PVE/LXC/Config.pm > +++ b/src/PVE/LXC/Config.pm > @@ -450,6 +450,63 @@ my $features_desc = { > }, > }; > > +my $cicustom_fmt = { > + user => { > + type => 'string', > + optional => 1, > + description => 'To pass a custom file containing all user data to the container via cloud-init.', > + format => 'pve-volume-id', > + format_description => 'volume', > + }, > + vendor => { > + type => 'string', > + optional => 1, > + description => 'To pass a custom file containing all vendor data to the container via cloud-init.', > + format => 'pve-volume-id', > + format_description => 'volume', > + }, ...i.e. it's missing here. This might be an oversight, because the doc patch mentions it in an example command: 'pct set 9000 --cicustom "user=<volume>,meta=<volume>"' > +}; > +PVE::JSONSchema::register_format('pve-pct-cicustom', $cicustom_fmt); > + > +my $confdesc_cloudinit = { > + cienable => { > + optional => 1, > + type => 'boolean', > + description => "cloud-init: provide cloud-init configuration to container.", Missing the default. > + }, > + ciuser => { > + optional => 1, > + type => 'string', > + description => "cloud-init: User name to change ssh keys and password for instead of the" > + ." image's configured default user.", > + }, > + cipassword => { > + optional => 1, > + type => 'string', > + description => 'cloud-init: Password to assign the user. Using this is generally not' > + .' recommended. Use ssh keys instead. Also note that older cloud-init versions do not' > + .' support hashed passwords.', > + }, > + ciupgrade => { > + optional => 1, > + type => 'boolean', > + description => 'cloud-init: do an automatic package update on boot.' Missing the default. > + }, > + cicustom => { > + optional => 1, > + type => 'string', > + description => 'cloud-init: Specify custom files to replace the automatically generated' > + .' ones at start.', > + format => 'pve-pct-cicustom', > + }, > + sshkeys => { > + optional => 1, > + type => 'string', > + format => 'urlencoded', > + description => "cloud-init: Setup public SSH keys (one key per line, OpenSSH format).", > + }, > +}; > + > my $confdesc = { > lock => { > optional => 1, > @@ -622,6 +679,10 @@ my $confdesc = { > }, > }; > > +foreach my $key (keys %$confdesc_cloudinit) { Style nit: use "for" > + $confdesc->{$key} = $confdesc_cloudinit->{$key}; > +} > + > my $valid_lxc_conf_keys = { > 'lxc.apparmor.profile' => 1, > 'lxc.apparmor.allow_incomplete' => 1, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel