From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 525591FF161
for <inbox@lore.proxmox.com>; Wed, 18 Dec 2024 15:08:31 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4EDDB176A8;
Wed, 18 Dec 2024 15:08:30 +0100 (CET)
Message-ID: <032103c3-7ed4-437a-b1d2-96e96018dc8b@proxmox.com>
Date: Wed, 18 Dec 2024 15:07:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20241217154814.82121-1-f.ebner@proxmox.com>
<20241217154814.82121-8-f.ebner@proxmox.com>
From: Filip Schauer <f.schauer@proxmox.com>
In-Reply-To: <20241217154814.82121-8-f.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.025 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v2 storage 07/10] iscsi direct plugin:
support volume export
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
To test exporting a volume from the `iscsidirect` storage backend, I
installed `libiscsi-bin` and configured the storage in
`/etc/pve/storage.cfg` by using the same options as I used for the
`iscsi` storage.
```
$ pvesm export tgtdirectstorage:lun1 raw+size output
```
Then I imported the volume into a directory storage:
```
$ pvesm import local:117/vm-117-disk-0.raw raw+size output
Formatting '/var/lib/vz/images/117/vm-117-disk-0.raw', fmt=raw
size=4290772992 preallocation=off
65472+0 records in
65472+0 records out
4290772992 bytes (4.3 GB, 4.0 GiB) copied, 3.62069 s, 1.2 GB/s
successfully imported 'local:117/vm-117-disk-0.raw'
```
Assigned the disk to a VM and it also booted up just fine.
Trying to import into a user mode iSCSI storage fails as expected:
```
$ pvesm import tgtdirectstorage raw+size output
cannot import into volume 'tgtdirectstorage'
```
Tested-by: Filip Schauer <f.schauer@proxmox.com>
On 17/12/2024 16:48, Fiona Ebner wrote:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
> src/PVE/Storage/ISCSIDirectPlugin.pm | 63 ++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm b/src/PVE/Storage/ISCSIDirectPlugin.pm
> index 6f02eee..e5f6808 100644
> --- a/src/PVE/Storage/ISCSIDirectPlugin.pm
> +++ b/src/PVE/Storage/ISCSIDirectPlugin.pm
> @@ -2,9 +2,12 @@ package PVE::Storage::ISCSIDirectPlugin;
>
> use strict;
> use warnings;
> +
> use IO::File;
> +use JSON qw(decode_json);
> use HTTP::Request;
> use LWP::UserAgent;
> +
> use PVE::Tools qw(run_command file_read_firstline trim dir_glob_regex dir_glob_foreach);
> use PVE::Storage::Plugin;
> use PVE::JSONSchema qw(get_standard_option);
> @@ -252,4 +255,64 @@ sub volume_has_feature {
> return undef;
> }
>
> +sub volume_export_formats {
> + my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_;
> +
> + return () if defined($snapshot); # not supported
> + return () if defined($base_snapshot); # not supported
> + return () if $with_snapshots; # not supported
> + return ('raw+size');
> +}
> +
> +sub volume_export {
> + my (
> + $class,
> + $scfg,
> + $storeid,
> + $fh,
> + $volname,
> + $format,
> + $snapshot,
> + $base_snapshot,
> + $with_snapshots,
> + ) = @_;
> +
> + die "volume export format $format not available for $class\n" if $format ne 'raw+size';
> + die "cannot export volumes together with their snapshots in $class\n" if $with_snapshots;
> + die "cannot export an incremental stream in $class\n" if defined($base_snapshot);
> + die "cannot export a snapshot in $class\n" if defined($snapshot);
> +
> + my $file = $class->path($scfg, $volname, $storeid, $snapshot);
> +
> + my $json = '';
> + run_command(
> + ['/usr/bin/qemu-img', 'info', '-f', 'raw', '--output=json', $file],
> + outfunc => sub { $json .= shift },
> + );
> + die "failed to query size information for '$file' with qemu-img\n" if !$json;
> + my $info = eval { decode_json($json) };
> + die "could not parse qemu-img info command output for '$file' - $@\n" if $@;
> +
> + my ($size) = ($info->{'virtual-size'} =~ /^(\d+)$/); # untaint
> + die "size '$size' not an integer\n" if !defined($size);
> + $size = int($size); # coerce back from string
> +
> + PVE::Storage::Plugin::write_common_header($fh, $size);
> + run_command(
> + ['qemu-img', 'dd', 'bs=64k', "if=$file", '-f', 'raw', '-O', 'raw'],
> + output => '>&'.fileno($fh),
> + );
> + return;
> +}
> +
> +sub volume_import_formats {
> + my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_;
> +
> + return ();
> +}
> +
> +sub volume_import {
> + die "volume import is not possible on iscsi storage\n";
> +}
> +
> 1;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel