From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5DAA769C01 for ; Fri, 25 Mar 2022 09:35:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 54B1337522 for ; Fri, 25 Mar 2022 09:35:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D522A37517 for ; Fri, 25 Mar 2022 09:35:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A956046F8C for ; Fri, 25 Mar 2022 09:35:49 +0100 (CET) Message-ID: <02da4f21-aa0c-4c93-6e0f-cdb28c3b4307@proxmox.com> Date: Fri, 25 Mar 2022 09:35:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Matthias Heiserer References: <20220324113331.681971-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220324113331.681971-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit 1/2] Utils: add calculate max button width hack X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 08:35:50 -0000 On 24.03.22 12:33, Matthias Heiserer wrote: > The same code is used once in widget toolkit and twice in PVE already, > so it makes sense to add it as a separate function. > > Signed-off-by: Matthias Heiserer > --- > src/Utils.js | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/Utils.js b/src/Utils.js > index 6a03057..27fcd1d 100644 > --- a/src/Utils.js > +++ b/src/Utils.js > @@ -1272,6 +1272,17 @@ utilities: { > .map(val => val.charCodeAt(0)), > ); > }, > + > + calculateWidth: function(btn) { way to general name for such a specific use case, NACK, rather: maxAltTextButtonWidth > + // HACK: calculate the max button width on first render to avoid toolbar glitches comment could go in line above the function declaration. > + let defSize = btn.getSize().width; now that we're not on a deeper indentation level we can also spell out the variable names more nicely. > + > + btn.setText(btn.altText); > + let altSize = btn.getSize().width; > + > + btn.setText(btn.defaultText); > + btn.setWidth(altSize > defSize ? altSize : defSize); > + }, > }, > > singleton: true,