From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 422C51FF0B4 for ; Tue, 10 Nov 2026 17:23:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A78E921624; Tue, 10 Nov 2026 17:23:28 +0100 (CET) Message-ID: <0224db28-a7eb-425a-a5d7-f30c667eaf4d@proxmox.com> Date: Tue, 10 Nov 2026 17:23:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-qemu-server-rs v3 2/9] pci: legacy: generate pci bridges To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20261106132604.2556840-1-d.csapak@proxmox.com> <20261106132604.2556840-3-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20261106132604.2556840-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794327804475 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.284 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 43HVRCHJJZ4YZJGT4QBW7KLTHJW5OIWV X-Message-ID-Hash: 43HVRCHJJZ4YZJGT4QBW7KLTHJW5OIWV X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 06.11.26 um 2:26 PM schrieb Dominik Csapak: > Besides the address of a single device, we also need the list of > bridges a guest has to be started with. Return them from > `pci_bus_devices`, which is intended to return all devices that form a > bus, since those must come before the devices using them on the > commandline. > > The list itself follows the perl implementation: > * q35 machines already have the bridges up to 3 in their machine > config > * pci.3 is only needed for virtio-scsi-single > * pci.4 is only needed for scsi controllers with an index > 1, or > starting with machine version 11.1 > > Signed-off-by: Dominik Csapak Reviewed-by: Fiona Ebner