From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F069699B20 for ; Wed, 11 Oct 2023 11:38:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D6C046B5E for ; Wed, 11 Oct 2023 11:38:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 11 Oct 2023 11:38:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 877B545F05 for ; Wed, 11 Oct 2023 11:38:55 +0200 (CEST) Message-ID: <01e2d75b-c87a-4bc9-98f4-77f4ccf4df83@proxmox.com> Date: Wed, 11 Oct 2023 11:38:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Friedrich Weber To: Proxmox VE development discussion , Stoiko Ivanov References: <20231009125242.3857753-1-s.ivanov@proxmox.com> <20231009125242.3857753-4-s.ivanov@proxmox.com> Content-Language: en-US In-Reply-To: <20231009125242.3857753-4-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.144 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 1/1] pve7to8: check for proper grub meta-package for bootmode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2023 09:38:58 -0000 On 09/10/2023 14:52, Stoiko Ivanov wrote: > + } elsif ( ! -f "/usr/share/doc/grub-efi-amd64/changelog.Debian.gz" ) { > + log_warn( > + "System booted in uefi mode but grub-efi-amd64 meta-package not installed" > + . " new grub versions will not be installed to /boot/efi!" > + . " Install grub-efi-amd64." > ); I do like the exclamation mark, but I still think some punctuation (if not newline) between "[...] not installed" and "new grub versions [...]" would be good. Currently, the message reads like this: WARN: System booted in uefi mode but grub-efi-amd64 meta-package notinstalled new grub versions will not be installed to /boot/efi! Install grub-efi-amd64. which is a bit hard to parse -- the following seems easier to parse (note the extra comma): WARN: System booted in uefi mode but grub-efi-amd64 meta-package not installed, new grub versions will not be installed to /boot/efi! Install grub-efi-amd64. Sorry for obsessing over the punctuation here, but I suspect there are a lot of UEFI-booted PVE 7 installs with LVM root, so it would be good to reduce the potential for confusion as much as possible. The exact phrasing aside, consider this: Tested-by: Friedrich Weber Can confirm that with this patch, * pve7to8 prints the warning on UEFI-booted system with root on LVM and grub-pc installed * pve7to8 does *not* print the warning on ** the same system when grub-efi-amd64 is installed ** UEFI-booted system with root on ZFS (using systemd-boot) ** legacy-booted system with root on LVM or ZFS