From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E14006A53D for ; Fri, 5 Mar 2021 08:24:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D0F3F212E8 for ; Fri, 5 Mar 2021 08:24:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1E2CF212D8 for ; Fri, 5 Mar 2021 08:24:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DC83C43546 for ; Fri, 5 Mar 2021 08:24:19 +0100 (CET) To: pve-devel@lists.proxmox.com, Stefan Reiter References: <20210304125209.24078-1-s.reiter@proxmox.com> From: Fabian Ebner Message-ID: <01cf3904-1fa6-983b-e8f8-d4aae50b93a5@proxmox.com> Date: Fri, 5 Mar 2021 08:24:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210304125209.24078-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, machine.pm, parse-machines.pl, nodes.pm] Subject: Re: [pve-devel] [PATCH 0/7] Work around QEMU 5.2 windows incompatibility X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 07:24:21 -0000 Didn't follow this issue too closely, but what about restoring a pre-QEMU-ACPI-patch Windows VM backup in a post-QEMU-ACPI-patch world? Those would need to get pinned as well, right? Doing the pinning itself on restore shouldn't be difficult, but a good way to detect when it's needed is needed. Am 04.03.21 um 13:52 schrieb Stefan Reiter: > ...and make machine version configurable in the GUI, to allow users to return to > the default behaviour of always using the latest one. > > The workaround is based on a postinst script running when upgrading the > qemu-server package, which sets the machine version of all effected Windows VMs > to pc-(i440fx|q35)-5.1 to pin them to the last version still using the old ACPI > table layout. > > Note: the postinst patch requires Fabian's #3301 series: > https://lists.proxmox.com/pipermail/pve-devel/2021-March/047175.html > > > pve-qemu: Stefan Reiter (2): > add static supported machines file > add ACPI compat patch for 5.1 and older machine types > > debian/parse-machines.pl | 21 ++++ > ...restore-device-paths-for-pre-5.1-vms.patch | 108 ++++++++++++++++++ > debian/patches/series | 1 + > debian/rules | 4 +- > 4 files changed, 133 insertions(+), 1 deletion(-) > create mode 100755 debian/parse-machines.pl > create mode 100644 debian/patches/extra/0009-i386-acpi-restore-device-paths-for-pre-5.1-vms.patch > > qemu-server: Stefan Reiter (2): > api: add Machine module to query machine types > add postinst with Windows device incompatibility workaround > > PVE/API2/Qemu/Machine.pm | 49 +++++++++++++++++++++ > PVE/API2/Qemu/Makefile | 2 +- > debian/postinst | 95 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 145 insertions(+), 1 deletion(-) > create mode 100644 PVE/API2/Qemu/Machine.pm > create mode 100755 debian/postinst > > manager: Stefan Reiter (3): > api: register Qemu::Machine call > ui: create MachineEdit window > ui: MachineEdit: add option for machine version pinning > > PVE/API2/Nodes.pm | 6 ++ > www/manager6/Makefile | 1 + > www/manager6/qemu/HardwareView.js | 16 +---- > www/manager6/qemu/MachineEdit.js | 107 ++++++++++++++++++++++++++++++ > 4 files changed, 115 insertions(+), 15 deletions(-) > create mode 100644 www/manager6/qemu/MachineEdit.js >