From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id B531A69EC0
 for <pve-devel@lists.proxmox.com>; Wed, 24 Mar 2021 09:37:36 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B30B036133
 for <pve-devel@lists.proxmox.com>; Wed, 24 Mar 2021 09:37:36 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 3932836126
 for <pve-devel@lists.proxmox.com>; Wed, 24 Mar 2021 09:37:36 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 033DB430F3
 for <pve-devel@lists.proxmox.com>; Wed, 24 Mar 2021 09:37:36 +0100 (CET)
To: pve-devel@lists.proxmox.com, o.bektas@proxmox.com
References: <20210322140045.763332-1-o.bektas@proxmox.com>
 <20210322140045.763332-3-o.bektas@proxmox.com>
From: Fabian Ebner <f.ebner@proxmox.com>
Message-ID: <01b43315-23f3-0df4-f23a-2d6a84a7bb33@proxmox.com>
Date: Wed, 24 Mar 2021 09:37:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210322140045.763332-3-o.bektas@proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.006 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [spiceproxy.pm, pveproxy.pm]
Subject: Re: [pve-devel] [PATCH v3 manager 2/3] proxy: allow setting
 LISTEN_IP for pveproxy and spiceproxy
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2021 08:37:36 -0000

After these first two patches, the default behavior is different:
Previously, it would only listen for either IPv4 or IPv6 (depending on 
what get_host_address_family would return), while now it listens for 
both. Not sure if that's a problem though?

Am 22.03.21 um 15:00 schrieb Oguz Bektas:
> the $host variable is set to "::0" by default to listen on wildcard
> (with 'Domain' => PF_INET6).
> 
> if 'LISTEN_IP' is defined in /etc/default/pveproxy, that IP will be used
> instead.
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>   PVE/Service/pveproxy.pm   | 4 ++--
>   PVE/Service/spiceproxy.pm | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm
> index 571a6bf5..4ecd442a 100755
> --- a/PVE/Service/pveproxy.pm
> +++ b/PVE/Service/pveproxy.pm
> @@ -69,8 +69,8 @@ sub init {
>       my $lockfh = IO::File->new(">>${accept_lock_fn}") ||
>   	die "unable to open lock file '${accept_lock_fn}' - $!\n";
>   
> -    my $family = PVE::Tools::get_host_address_family($self->{nodename});
> -    my $socket = $self->create_reusable_socket(8006, undef, $family);
> +    my $listen_ip = $proxyconf->{LISTEN_IP} // "::0";
> +    my $socket = $self->create_reusable_socket(8006, $listen_ip);
>   
>       my $dirs = {};
>   
> diff --git a/PVE/Service/spiceproxy.pm b/PVE/Service/spiceproxy.pm
> index f8e06b60..24be0ed7 100755
> --- a/PVE/Service/spiceproxy.pm
> +++ b/PVE/Service/spiceproxy.pm
> @@ -39,8 +39,8 @@ sub init {
>       my $lockfh = IO::File->new(">>${accept_lock_fn}") ||
>   	die "unable to open lock file '${accept_lock_fn}' - $!\n";
>   
> -    my $family = PVE::Tools::get_host_address_family($self->{nodename});
> -    my $socket = $self->create_reusable_socket(3128, undef, $family);
> +    my $listen_ip = $proxyconf->{LISTEN_IP} // "::0";
> +    my $socket = $self->create_reusable_socket(3128, $listen_ip);
>   
>       $self->{server_config} = {
>   	keep_alive => 0,
>