From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2C7C094AB for ; Thu, 31 Mar 2022 15:01:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5B2B81BC66 for ; Thu, 31 Mar 2022 15:01:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DC8791BC5B for ; Thu, 31 Mar 2022 15:01:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B60B1463A9; Thu, 31 Mar 2022 15:01:23 +0200 (CEST) Message-ID: <012e825c-961f-3640-297d-d8b2a9ea0690@proxmox.com> Date: Thu, 31 Mar 2022 15:01:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, aderumier@odiso.com References: <20210609115417.3326775-1-aderumier@odiso.com> <20210609115417.3326775-4-aderumier@odiso.com> From: Fabian Ebner In-Reply-To: <20210609115417.3326775-4-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: Re: [pve-devel] [PATCH v3 qemu-server 3/7] cloudinit: make cloudnit options fastplug X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 13:01:55 -0000 Am 09.06.21 um 13:54 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 30 +++--------------------------- > 1 file changed, 3 insertions(+), 27 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 6ddac72..0be4c45 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -4530,9 +4530,10 @@ sub vmconfig_hotplug_pending { > $errors->{$opt} = "hotplug problem - $msg"; > }; > > + my @cloudinit_opts = keys %$confdesc_cloudinit; > my $changes = 0; > foreach my $opt (keys %{$conf->{pending}}) { # add/change > - if ($fast_plug_option->{$opt}) { > + if ($fast_plug_option->{$opt} || grep { $_ eq $opt } @cloudinit_opts) { Maybe add them to the fast_plug_option hash directly? Then deleting a cloudinit option would also be fastplugged (in the pending_delete_hash handling below, it currently only checks for $fast_plug_option). > $conf->{$opt} = $conf->{pending}->{$opt}; > delete $conf->{pending}->{$opt}; > $changes = 1;