From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <0100017e6f20ab89-937c99e8-c40c-492b-85cf-f349752b86a5-000000@amazonses.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9E8C261DD3 for ; Tue, 18 Jan 2022 22:51:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E5FA2FCC3 for ; Tue, 18 Jan 2022 22:51:25 +0100 (CET) Received: from a8-50.smtp-out.amazonses.com (a8-50.smtp-out.amazonses.com [54.240.8.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 816B72FCB8 for ; Tue, 18 Jan 2022 22:51:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qmjwmcbdebflivjf5q7gyd5xjt54qgwu; d=nicksherlock.com; t=1642541919; h=From:To:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=2qRvmmBG0a+pNKCx9gA8yw6oqvVljLeciu6gTUMbNlM=; b=UodFgBWDSpNS9d8azPKwpdQkTminm/zyUUWW99lXgcFX3aUA1vxIQePy32gPh/KE opLGlu2QXcZDu2H+PGdlVUTJC5WU8Aw/mqwO9GIrERwnZUpOPLm2X56QMmLNOG5/HN2 1Y4Xwl8CLbhBKAiw1SnHBeK+Ug2bhsVIqrC8CH6FU2oFva4wNn9IGN8QvcdPattLZyY fyzwyeh8EXBpbcGXiRXV9M4lKKVjNCeCd2pRuv2EwKSV+waRACpq7a9pirywMYcfaQL OiHKPRwyvcXyzaelRMpUKwqw3yAi9gw1NQ+0uO66qIOLhfC0mYXiaEZRtWQ8uImAOjK DCIkwkllHQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1642541919; h=From:To:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Feedback-ID; bh=2qRvmmBG0a+pNKCx9gA8yw6oqvVljLeciu6gTUMbNlM=; b=G2h0+u+xoMdQ9tv1cgLxtnRhjdjrKtD9BYmPjnOPCF/J1tLzs2OdujEekjDFuQdg snEJQIYM5i0IWnIWUG1PLUIznG0t6jAuEJNyDGCR2Pd94lFoQGDdyWPG5BsahS1rmBQ WefQ12EN8jLUujXQMuJsrGDU6bv28UN386bPhBDY= From: Nicholas Sherlock To: pve-devel@lists.proxmox.com Date: Tue, 18 Jan 2022 21:38:39 +0000 Message-ID: <0100017e6f20ab89-937c99e8-c40c-492b-85cf-f349752b86a5-000000@email.amazonses.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Feedback-ID: 1.us-east-1.Zun7nGVgCINWr9mhx6IDxIE7OFgiOsHC8NqBQnS80nA=:AmazonSES X-SES-Outgoing: 2022.01.18-54.240.8.50 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain HEADER_FROM_DIFFERENT_DOMAINS 0.248 From and EnvelopeFrom 2nd level mail domains are different RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust RCVD_IN_MSPIKE_H2 -0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pci.pm, 8006.pid, nicksherlock.com] Subject: [pve-devel] [PATCH v2 qemu-server] pci: allow override of PCI vendor/device ids X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 21:51:55 -0000 From: Nicholas Sherlock This allows mobile- and vGPUs to be presented to the guest as if they were the original desktop variants of the card. It also allows device-ID variants that guests don't know about to be renamed to match compatible sibling devices the guest does have drivers for (e.g. to remove manufacturer-specific vendor ID variants that prevent the use of a device which would otherwise have a supported chipset) e.g. hostpci0: 03:00,vendor-id=0x8086,device-id=0x10f6 Signed-off-by: Nicholas Sherlock --- PVE/QemuServer/PCI.pm | 31 ++++++++++++++++ .../q35-linux-hostpci-x-pci-overrides.conf | 16 +++++++++ ...q35-linux-hostpci-x-pci-overrides.conf.cmd | 35 +++++++++++++++++++ 3 files changed, 82 insertions(+) create mode 100644 test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf create mode 100644 test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf.cmd diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm index 4033784..70987d8 100644 --- a/PVE/QemuServer/PCI.pm +++ b/PVE/QemuServer/PCI.pm @@ -77,6 +77,34 @@ The type of mediated device to use. An instance of this type will be created on startup of the VM and will be cleaned up when the VM stops. EODESCR + }, + 'vendor-id' => { + type => 'string', + pattern => qr/^0x[0-9a-fA-F]{4}$/, + format_description => 'hex id', + optional => 1, + description => "Override PCI vendor ID visible to guest" + }, + 'device-id' => { + type => 'string', + pattern => qr/^0x[0-9a-fA-F]{4}$/, + format_description => 'hex id', + optional => 1, + description => "Override PCI device ID visible to guest" + }, + 'sub-vendor-id' => { + type => 'string', + pattern => qr/^0x[0-9a-fA-F]{4}$/, + format_description => 'hex id', + optional => 1, + description => "Override PCI subsystem vendor ID visible to guest" + }, + 'sub-device-id' => { + type => 'string', + pattern => qr/^0x[0-9a-fA-F]{4}$/, + format_description => 'hex id', + optional => 1, + description => "Override PCI subsystem device ID visible to guest" } }; PVE::JSONSchema::register_format('pve-qm-hostpci', $hostpci_fmt); @@ -457,6 +485,9 @@ sub print_hostpci_devices { $devicestr .= ",multifunction=on" if $multifunction; $devicestr .= ",romfile=/usr/share/kvm/$d->{romfile}" if $d->{romfile}; $devicestr .= ",bootindex=$bootorder->{$id}" if $bootorder->{$id}; + for my $option (qw(vendor-id device-id sub-vendor-id sub-device-id)) { + $devicestr .= ",x-pci-$option=$d->{$option}" if $d->{$option}; + } } push @$devices, '-device', $devicestr; diff --git a/test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf b/test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf new file mode 100644 index 0000000..b726a3a --- /dev/null +++ b/test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf @@ -0,0 +1,16 @@ +# TEST: Overriding PCI vendor/device IDs reported to guest +bios: ovmf +bootdisk: scsi0 +cores: 1 +efidisk0: local:100/vm-100-disk-1.qcow2,size=128K +hostpci0: 00:ff.1,vendor-id=0x1234,device-id=0x5678,sub-vendor-id=0x2233,sub-device-id=0x0000 +hostpci1: d0:13.0,pcie=1,vendor-id=0x1234,device-id=0x5678 +machine: q35 +memory: 512 +net0: virtio=2E:01:68:F9:9C:87,bridge=vmbr0 +numa: 1 +ostype: l26 +scsihw: virtio-scsi-pci +smbios1: uuid=3dd750ce-d910-44d0-9493-525c0be4e687 +sockets: 2 +vmgenid: 54d1c06c-8f5b-440f-b5b2-6eab1380e13d diff --git a/test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf.cmd b/test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf.cmd new file mode 100644 index 0000000..7a215c9 --- /dev/null +++ b/test/cfg2cmd/q35-linux-hostpci-x-pci-overrides.conf.cmd @@ -0,0 +1,35 @@ +/usr/bin/kvm \ + -id 8006 \ + -name vm8006 \ + -no-shutdown \ + -chardev 'socket,id=qmp,path=/var/run/qemu-server/8006.qmp,server=on,wait=off' \ + -mon 'chardev=qmp,mode=control' \ + -chardev 'socket,id=qmp-event,path=/var/run/qmeventd.sock,reconnect=5' \ + -mon 'chardev=qmp-event,mode=control' \ + -pidfile /var/run/qemu-server/8006.pid \ + -daemonize \ + -smbios 'type=1,uuid=3dd750ce-d910-44d0-9493-525c0be4e687' \ + -drive 'if=pflash,unit=0,format=raw,readonly=on,file=/usr/share/pve-edk2-firmware//OVMF_CODE.fd' \ + -drive 'if=pflash,unit=1,format=qcow2,id=drive-efidisk0,file=/var/lib/vz/images/100/vm-100-disk-1.qcow2' \ + -global 'ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off' \ + -smp '2,sockets=2,cores=1,maxcpus=2' \ + -nodefaults \ + -boot 'menu=on,strict=on,reboot-timeout=1000,splash=/usr/share/qemu-server/bootsplash.jpg' \ + -vnc 'unix:/var/run/qemu-server/8006.vnc,password=on' \ + -cpu kvm64,enforce,+kvm_pv_eoi,+kvm_pv_unhalt,+lahf_lm,+sep \ + -m 512 \ + -object 'memory-backend-ram,id=ram-node0,size=256M' \ + -numa 'node,nodeid=0,cpus=0,memdev=ram-node0' \ + -object 'memory-backend-ram,id=ram-node1,size=256M' \ + -numa 'node,nodeid=1,cpus=1,memdev=ram-node1' \ + -readconfig /usr/share/qemu-server/pve-q35-4.0.cfg \ + -device 'vmgenid,guid=54d1c06c-8f5b-440f-b5b2-6eab1380e13d' \ + -device 'usb-tablet,id=tablet,bus=ehci.0,port=1' \ + -device 'vfio-pci,host=0000:00:ff.1,id=hostpci0,bus=pci.0,addr=0x10,x-pci-vendor-id=0x1234,x-pci-device-id=0x5678,x-pci-sub-vendor-id=0x2233,x-pci-sub-device-id=0x0000' \ + -device 'vfio-pci,host=0000:d0:13.0,id=hostpci1,bus=ich9-pcie-port-2,addr=0x0,x-pci-vendor-id=0x1234,x-pci-device-id=0x5678' \ + -device 'VGA,id=vga,bus=pcie.0,addr=0x1' \ + -device 'virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3' \ + -iscsi 'initiator-name=iqn.1993-08.org.debian:01:aabbccddeeff' \ + -netdev 'type=tap,id=net0,ifname=tap8006i0,script=/var/lib/qemu-server/pve-bridge,downscript=/var/lib/qemu-server/pve-bridgedown,vhost=on' \ + -device 'virtio-net-pci,mac=2E:01:68:F9:9C:87,netdev=net0,bus=pci.0,addr=0x12,id=net0,bootindex=300' \ + -machine 'type=q35+pve0' -- 2.34.1