From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id B9011724C5
for <pve-devel@lists.proxmox.com>; Tue, 25 May 2021 15:26:43 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A6EA52C6BB
for <pve-devel@lists.proxmox.com>; Tue, 25 May 2021 15:26:13 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 395F12C6AC
for <pve-devel@lists.proxmox.com>; Tue, 25 May 2021 15:26:13 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 12FB5465C2
for <pve-devel@lists.proxmox.com>; Tue, 25 May 2021 15:26:13 +0200 (CEST)
Message-ID: <00ebc5fa-145a-10ea-62e1-812d1ada7471@proxmox.com>
Date: Tue, 25 May 2021 15:26:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101
Thunderbird/89.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
References: <20210525131559.1007131-1-o.bektas@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210525131559.1007131-1-o.bektas@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.007 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [base.pm]
Subject: Re: [pve-devel] [PATCH container] setup: make randomize_crontab a
state subroutine
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 25 May 2021 13:26:43 -0000
On 25.05.21 15:15, Oguz Bektas wrote:
> for consistency in post_create_hook. still works as expected
>
what's the reason/benefit again?
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> src/PVE/LXC/Setup/Base.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> index d73335b..be41874 100644
> --- a/src/PVE/LXC/Setup/Base.pm
> +++ b/src/PVE/LXC/Setup/Base.pm
> @@ -422,7 +422,7 @@ sub set_user_authorized_ssh_keys {
> $self->ct_modify_file("$home/.ssh/authorized_keys", $ssh_keys, perms => 0700);
> }
>
> -my $randomize_crontab = sub {
> +sub randomize_crontab {
> my ($self, $conf) = @_;
>
> my @files;
> @@ -450,7 +450,7 @@ my $randomize_crontab = sub {
> }
> $self->ct_file_set_contents($filename, $new);
> }
> -};
> +}
>
> sub set_timezone {
> my ($self, $conf) = @_;
> @@ -493,7 +493,7 @@ sub post_create_hook {
>
> $self->template_fixup($conf);
>
> - &$randomize_crontab($self, $conf);
> + $self->randomize_crontab($conf);
>
> $self->set_user_password($conf, 'root', $root_password);
> $self->set_user_authorized_ssh_keys($conf, 'root', $ssh_keys) if $ssh_keys;
>