From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <w.bumiller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 315D2B83D8
for <pmg-devel@lists.proxmox.com>; Mon, 4 Dec 2023 11:57:24 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 130D0BCC1
for <pmg-devel@lists.proxmox.com>; Mon, 4 Dec 2023 11:56:54 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pmg-devel@lists.proxmox.com>; Mon, 4 Dec 2023 11:56:53 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DF307443B2
for <pmg-devel@lists.proxmox.com>; Mon, 4 Dec 2023 11:56:52 +0100 (CET)
Date: Mon, 4 Dec 2023 11:56:51 +0100
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Folke Gleumes <f.gleumes@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Message-ID: <tngr4lqtaxwlvmdjozkgkyr2jlwzrlqoxdlito7os6ohbd26ar@q5u75ip57x3u>
References: <20231114141408.228705-1-f.gleumes@proxmox.com>
<20231114141408.228705-3-f.gleumes@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231114141408.228705-3-f.gleumes@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.096 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pmg-devel] applied: [PATCH acme-rs 2/8] add meta fields returned
by the directory
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 04 Dec 2023 10:57:24 -0000
applied the acme-rs patches
Note: proxmox-acme-rs.git has now been merged into proxmox.git.
Also, the `-rs` suffix has been dropped from the crate name.
On Tue, Nov 14, 2023 at 03:14:01PM +0100, Folke Gleumes wrote:
> According to the rfc, the meta field contains additional fields that
> weren't covered by the Meta struct. Of the additional fields, only
> external_account_required will be used in the near future, but others
> were added for completeness and the case that they might be used in the
> future.
>
> Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
> ---
> src/directory.rs | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/src/directory.rs b/src/directory.rs
> index 755ea8c..a9d31f2 100644
> --- a/src/directory.rs
> +++ b/src/directory.rs
> @@ -47,6 +47,18 @@ pub struct Meta {
> /// The terms of service. This is typically in the form of an URL.
> #[serde(skip_serializing_if = "Option::is_none")]
> pub terms_of_service: Option<String>,
> +
> + /// Flag indicating if EAB is required, None is equivalent to false
> + #[serde(skip_serializing_if = "Option::is_none")]
> + pub external_account_required: Option<bool>,
> +
> + /// Website with information about the ACME Server
> + #[serde(skip_serializing_if = "Option::is_none")]
> + pub website: Option<String>,
> +
> + /// List of hostnames used by the CA, intended for the use with caa dns records
> + #[serde(skip_serializing_if = "Option::is_none")]
> + pub caa_identities: Option<Vec<String>>,
^ I dropped the `Option<>` there and added `#[serde(default)]` so
deserializing works without it.