From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 565B61FF16B for ; Fri, 26 Sep 2025 11:15:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62A35BBFF; Fri, 26 Sep 2025 11:16:27 +0200 (CEST) From: Maximiliano Sandoval To: Hannes Laimer In-Reply-To: <20250924071314.41917-1-h.laimer@proxmox.com> (Hannes Laimer's message of "Wed, 24 Sep 2025 09:13:12 +0200") References: <20250924071314.41917-1-h.laimer@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Fri, 26 Sep 2025 11:16:24 +0200 Message-ID: MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758878169420 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api/pmg-gui v3 0/2] fix #3450: batch deletion/delivery for postfix queue X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmg-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" Hannes Laimer writes: > Adds a new POST endpoint that accepts both a type(delete/deliver) and a > list of id's. This is also how batch operations are done for quarantine. > > https://bugzilla.proxmox.com/show_bug.cgi?id=3450 > > v3, thanks @Thomas: > - code cleanup > - add more context to commit messages > - remove not needed checks when passing a list of ids to `postsuper -d -` > - ui: use INFO instead of WARNING confirm popup, same as we do for quarantine > - ui: no confirmation for flush of single mails, so existing behaviour of the > button does not change > > v2: > - instead of 'filter' use the IDs directly > - UI now doesn't have extra buttons, the existing Remove and Flush ones > will just work with either one or multiple selected items I tested the changes and the UX is as expected. Only issue I had is that the checkbox is too small to click manually when not using the filter, but that seems to be out-of-scope for the current series. The changes to pmg-api look OK to me. It is a bit unfortunate to potentially loop over a big number of `postqueue -i` calls in flush_queue_ids but from reading their man page I don't think they offer a better alternative. Tested-by: Maximiliano Sandoval -- Maximiliano _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel