From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DED95909CC for ; Thu, 16 Mar 2023 13:53:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A29514863 for ; Thu, 16 Mar 2023 13:52:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Mar 2023 13:52:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3CF454388E for ; Thu, 16 Mar 2023 13:52:42 +0100 (CET) Message-ID: Date: Thu, 16 Mar 2023 13:52:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20230308145235.37342-1-s.ivanov@proxmox.com> From: Dominik Csapak In-Reply-To: <20230308145235.37342-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api v2 0/4] improve local mail injection and add smtputf8 support X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2023 12:53:13 -0000 2 high level comments (one we already talked off-list, just to have it on record) 1. it seems that with this, at least the receiver gets encoded too many times, since i get a different recipient (with non-ascii characters) when hitting an ACCEPT rule vs. hitting a QUARANTINE rule and delivering it (not sure which patch is the faulty one here, but i guess api 4/4?) 2. AFAICS for 'reinject_local_mail' we decide to put SMTPUTF8 when the sender/receiver has non-ascii characters shouldn't we also make this depend on the config smtputf8 setting? since when we accept a mail right through, we don't scan the receiver/sender for that when no smtputf8 is set (postfix docs say here that they don't accept utf8 without SMTPUTF8 dialog, but it worked when testing here...) but do so when it goes into quarantine + deliver rationale is that when i have to disable smtputf8 support, it's because my downstream mail server does not accept it. in that case, every attempt to send such a mail will fail making the quarantine, etc. useless what do you think?