From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9F3ECAFD6 for ; Wed, 6 Apr 2022 10:13:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95C0227BB2 for ; Wed, 6 Apr 2022 10:13:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2837527BA7 for ; Wed, 6 Apr 2022 10:13:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF9B941FD8 for ; Wed, 6 Apr 2022 10:13:05 +0200 (CEST) Message-ID: Date: Wed, 6 Apr 2022 10:12:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Markus Frank , pmg-devel@lists.proxmox.com References: <20220330123215.41926-1-m.frank@proxmox.com> <20220330123215.41926-2-m.frank@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220330123215.41926-2-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] applied: [PATCH pmg-api v2 2/2] fix #3924: ldap: accept only valid email-address X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 08:13:06 -0000 On 30.03.22 14:32, Markus Frank wrote: > If a mail attribute contains special characters in ldap at the first > line, it will be set as primary email and results in a > "400 invalid format - value does not look like a valid email address" > Error-Statement in the webconsole. This mostly can happen if SIP > Addresses are in Active-Directory's proxyAddresses which begin with "SIP:". > > To make the validation more strict I changed the api to use > pmg-email-address and added a regex which looks for protocolnames (sip:) > that could be in proxyAddresses but are not compatible and skips these > addresses. > > Signed-off-by: Markus Frank > --- > src/PMG/API2/LDAP.pm | 5 ++--- > src/PMG/LDAPCache.pm | 8 +++++++- > 2 files changed, 9 insertions(+), 4 deletions(-) > > applied, thanks! Fixed up a few (trailing/extra) whitespace errors and shortened the m$ link.