From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA45F760F0 for ; Wed, 14 Jul 2021 18:03:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7D4114C81 for ; Wed, 14 Jul 2021 18:03:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8180A14C70 for ; Wed, 14 Jul 2021 18:03:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 16482418D0 for ; Wed, 14 Jul 2021 18:03:07 +0200 (CEST) Message-ID: Date: Wed, 14 Jul 2021 18:02:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20210714144430.241822-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210714144430.241822-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.625 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.368 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api 0/2] fix clusterjoin with ssh-keys !=2048 bits X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 16:03:08 -0000 On 14.07.21 16:44, Stoiko Ivanov wrote: > currently it's not possible to join a PMG cluster if the joining node (or > its root user) has a ssh-rsa key larger (or !=2048 bits) > > noticed the glitch while trying to join a PMG container based on > debian-bullseye. > > mid-term I'd like to also allow for other key-formats (ed25519) to work, but > since this needs a bit more work it can be postponed. > or drop using ssh completely ;-) > tested the patches on the same container (joining was successful) > > Stoiko Ivanov (2): > cluster: refactor ssh pubkey verification > cluster: add '=' to ssh pubkey pattern > > src/PMG/Cluster.pm | 5 +++-- > src/PMG/ClusterConfig.pm | 8 ++++++-- > 2 files changed, 9 insertions(+), 4 deletions(-) > applied both patches, added the missing space in the return statement and suffixed the method name with the _regex