From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6F7CB82405 for ; Sun, 28 Nov 2021 22:18:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D80629C1B for ; Sun, 28 Nov 2021 22:17:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 11D1A29C0A for ; Sun, 28 Nov 2021 22:17:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9D69943A90 for ; Sun, 28 Nov 2021 22:17:36 +0100 (CET) Message-ID: Date: Sun, 28 Nov 2021 22:17:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-GB To: Wolfgang Bumiller , pmg-devel@lists.proxmox.com References: <20211126135524.117846-1-w.bumiller@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211126135524.117846-1-w.bumiller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied-series: Re: [PATCH multiple 0/7] PMG TFA support X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Nov 2021 21:18:14 -0000 On 26/11/2021 14:55, Wolfgang Bumiller wrote: > This touches multiple repos as it required some more ground-work on the > rust side: applied series, thanks! Made a few follow ups: - restricted permissions of tfa add/modify to all but qusers, while the gui wouldn't allow it for those, it still could be set up over the API and that'd be confusing at best, as it would have any effect if I remember the quarantine user login flow somewhat - added tfa to the API index of /config and added one for webauthn in tfa, makes pmgsh work, among other things - implemented a webauthn config button, UX could surely get improved a bit but it does the job for now. - added libqrcode js dependency also in pmg-gui, as that's the actual user, albeit pmg-api can be fine too, it's not that clear with the split main-api and main-gui packages that we only have in PMG. - docs, well as at least some reference to the biggest newest feature in the docs may be expected by some users ;)