From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8F0701FF15C for ; Fri, 19 Sep 2025 09:38:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBBC3F764; Fri, 19 Sep 2025 09:38:19 +0200 (CEST) Message-ID: Date: Fri, 19 Sep 2025 09:37:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Stoiko Ivanov , Thomas Lamprecht References: <20250918143142.248758-1-h.laimer@proxmox.com> <20250918143142.248758-3-h.laimer@proxmox.com> <20250919012629.04dd0cd5@rosa.proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20250919012629.04dd0cd5@rosa.proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758267456497 X-SPAM-LEVEL: Spam detection results: 1 AWL -2.839 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SOMETLD_ARE_BAD_TLD 5 .bar, .beauty, .buzz, .cam, .casa, .cfd, .club, .date, .guru, .link, .live, .monster, .online, .press, .pw, .quest, .rest, .sbs, .shop, .stream, .top, .trade, .wiki, .work, .xyz TLD abuse PDS_OTHER_BAD_TLD 0.75 Untrustworthy TLDs RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [spamreport-verbose.tt, fetchmailrc.tt, pmgreport.tt, item.date, plain.tt, cf.in, spamreport-short.tt, proxmox.com] Subject: Re: [pmg-devel] [PATCH pmg-api v2 2/3] fix #1621: templates: add plain-text variant of short/verbose spam report X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmg-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" On 19.09.25 01:26, Stoiko Ivanov wrote: > On Thu, 18 Sep 2025 17:06:44 +0200 > Thomas Lamprecht wrote: > >> Am 18.09.25 um 16:32 schrieb Hannes Laimer: >>> Signed-off-by: Hannes Laimer >>> --- >>> v2: >>> - drop `subject:` line >>> >>> src/Makefile | 2 ++ >>> src/templates/spamreport-short.plain.tt | 9 +++++++++ >>> src/templates/spamreport-verbose.plain.tt | 18 ++++++++++++++++++ >>> 3 files changed, 29 insertions(+) >>> create mode 100644 src/templates/spamreport-short.plain.tt >>> create mode 100644 src/templates/spamreport-verbose.plain.tt >>> >>> diff --git a/src/Makefile b/src/Makefile >>> index 896319b..b75c818 100644 >>> --- a/src/Makefile >>> +++ b/src/Makefile >>> @@ -27,7 +27,9 @@ TEMPLATES = \ >>> fetchmailrc.tt \ >>> pmgreport.tt \ >>> spamreport-verbose.tt \ >>> + spamreport-verbose.plain.tt \ >>> spamreport-short.tt \ >>> + spamreport-short.plain.tt \ >>> main.cf.in \ >>> main.cf.in.demo \ >>> master.cf.in \ >>> diff --git a/src/templates/spamreport-short.plain.tt b/src/templates/spamreport-short.plain.tt >>> new file mode 100644 >>> index 0000000..2c13431 >>> --- /dev/null >>> +++ b/src/templates/spamreport-short.plain.tt >>> @@ -0,0 +1,9 @@ >>> +You received [% mailcount %] spam mail(s). >>> + >>> +[% SET links = [] %] >>> +Manage your spam quarantine: [% n = links.size + 1; links.push(managehref); %][[% n %]] >>> +Powered by Proxmox: [% n = links.size + 1; links.push('http://www.proxmox.com'); %][[% n %]] >>> + >>> +Links: >>> +[% FOREACH l IN links %][% loop.index + 1 %]: [% l %] >>> +[% END %] >>> diff --git a/src/templates/spamreport-verbose.plain.tt b/src/templates/spamreport-verbose.plain.tt >>> new file mode 100644 >>> index 0000000..1a0c182 >>> --- /dev/null >>> +++ b/src/templates/spamreport-verbose.plain.tt >>> @@ -0,0 +1,18 @@ >>> +[% SET links = [] -%] >>> +[% IF items.size -%] >>> +Spam quarantine entries for [% pmail %]: >>> + >>> +[% FOREACH item IN items %] >>> +- [% item.date %] [% item.time %] From: [% item.from_plain %] >>> + Subject: [% item.subject_plain %] [% n = links.size + 1; links.push(item.href); %][[% n %]] >>> + >>> +[% END %] >>> +[% ELSE %] >>> +No spam entries for the selected period. >>> +[% END %] >>> +Manage your spam quarantine: [% n = links.size + 1; links.push(managehref); %][[% n %]] >>> +Powered by Proxmox: [% n = links.size + 1; links.push('http://www.proxmox.com'); %][[% n %]] >>> + >>> +Links: >>> +[% FOREACH l IN links %][% loop.index + 1 %]: [% l %] >> >> Not sure about the reference like link lists at the bottom, if there's more than a >> handful of mails in the quarantine it gets quite hard to navigate fast, albeit >> searching for the reference number naturally is an option.. >> >> Maybe put at least the general link to the web UI at the top? That might be a good >> compromise where I do not have to scroll. >> >> I.e., move "Manage your spam quarantine" up and inline the link for that and probably >> also to www.proxmox.com as it's very short compared to the quarantine UI links anyway >> and not much is gained by placing it as reference link (and do s/http/https/ for that) >> >> Would like to hear some other opinions here (CC'in Fabian, as he is a big plain >> text mail user too, but others are naturally welcome to chime in too). > my idea was that a single link on top pointing to the quarantine, and one > to www.proxmox.com would be enough, without listing a large link for each > individual mail. (also for the html template there's links to > block-/welcomelist mails - so there I see the advantage a bit more (vs. > pre-selecting a row)) > makes sense, I'll send a v3 > > >> >>> +[% END %] >> >> >> >> _______________________________________________ >> pmg-devel mailing list >> pmg-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel >> >> > _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel