From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CF6D891032 for ; Fri, 10 Mar 2023 11:14:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B12D41F233 for ; Fri, 10 Mar 2023 11:14:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Mar 2023 11:14:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 09C5C42783; Fri, 10 Mar 2023 11:14:15 +0100 (CET) Message-ID: Date: Fri, 10 Mar 2023 11:14:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 To: Stefan Sterz , pmg-devel@lists.proxmox.com, Thomas Lamprecht , Stoiko Ivanov References: <20230308161840.2396113-1-s.sterz@proxmox.com> <20230309080015.28615-1-s.sterz@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20230309080015.28615-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api v1] proxy: add support for switching themes X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2023 10:14:16 -0000 replying here for the whole pmg part of the series all in all LGTM besides apart from some minor stuff that can be done as a follow-up: * in some parts the indentation is wrong * the mobile quarantine has still white dialogs (seems to be a bug in the framework7 version we use, updating to a current version seems non-trivial since we're 3 major versions behind, i can do it of course if wanted) * regarding the quarantine theme toggle: why should it not be possible to have a theme toggle when we respect the cookie? we can just read the parameter and as a fallback rely on the cookie? imho that would be a cleaner solution than inverting the whole mail if these points are not a problem @Thomas/@Stoiko, consider the pmg part Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak