From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3DC52941B1 for ; Wed, 21 Feb 2024 15:17:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1843E191AC for ; Wed, 21 Feb 2024 15:17:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Feb 2024 15:17:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3C414444F8 for ; Wed, 21 Feb 2024 15:17:27 +0100 (CET) Message-ID: Date: Wed, 21 Feb 2024 15:17:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pmg-devel@lists.proxmox.com References: <20240213113050.2349660-1-d.csapak@proxmox.com> <20240213113050.2349660-3-d.csapak@proxmox.com> From: Mira Limbeck In-Reply-To: <20240213113050.2349660-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.294 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [RFC PATCH pmg-gui 1/1] quarantine content: add checkbox for controlling image loading X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2024 14:17:58 -0000 On 2/13/24 12:30, Dominik Csapak wrote: > sometimes users don't want to load the images from the quarantine, > even when the admin configured 'viewimages' to on in the config. > (e.g. for privacy reasons) > > This checkbox sets/gets the state from the browser local storage > (so it's saved across reloads) to save the users preference of loading > images. > > If the backend is set to not load the images, the checkbox doesn't have > any effect. > > Signed-off-by: Dominik Csapak > --- > js/AttachmentQuarantine.js | 4 +++- > js/Makefile | 1 + > js/SpamQuarantine.js | 4 +++- > js/VirusQuarantine.js | 4 +++- > js/controller/QuarantineController.js | 19 ++++++++++++++++--- > js/form/ViewImages.js | 17 +++++++++++++++++ > 6 files changed, 43 insertions(+), 6 deletions(-) > create mode 100644 js/form/ViewImages.js > I'd prefer a button similar to the `Toggle Raw` and `Toggle Spam Info` ones that is off by default and only visible when there are images in the mail, but that's personal taste. Since we don't have any info on if there are even images in the mail, the checkbox seems to be the better option. Having it on by default doesn't change the behavior after applying the patch, so seems to be the better option in this case. Consider this patch: Tested-by: Mira Limbeck