From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B4330910D0 for ; Fri, 10 Mar 2023 11:24:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E6301F4B8 for ; Fri, 10 Mar 2023 11:24:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Mar 2023 11:24:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1772F43E8F for ; Fri, 10 Mar 2023 11:24:05 +0100 (CET) Message-ID: Date: Fri, 10 Mar 2023 11:24:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: Dominik Csapak , pmg-devel@lists.proxmox.com, Thomas Lamprecht , Stoiko Ivanov References: <20230308161840.2396113-1-s.sterz@proxmox.com> <20230309080015.28615-1-s.sterz@proxmox.com> Content-Language: en-US From: Stefan Sterz In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api v1] proxy: add support for switching themes X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2023 10:24:36 -0000 On 3/10/23 11:14, Dominik Csapak wrote: > replying here for the whole pmg part of the series > > all in all LGTM > > besides apart from some minor stuff that > can be done as a follow-up: > > * in some parts the indentation is wrong > * the mobile quarantine has still white dialogs >   (seems to be a bug in the framework7 version we use, updating >   to a current version seems non-trivial since we're 3 major >   versions behind, i can do it of course if wanted) i noticed that too, there are other issues that i still need to fix too (e.g., the logo on the login screen). but yeah, updating is probably the way to go here. since the mobile quarantine also displays the mail with a white background at the moment, i considered the dialogs a minor issue in comparison. i can also take a look at updating framework7 once i got some other fix-ups out. > * regarding the quarantine theme toggle: >   why should it not be possible to have a theme toggle when we respect > the cookie? >   we can just read the parameter and as a fallback rely on the cookie? >   imho that would be a cleaner solution than inverting the whole mail > well, you'd need to reload the mail preview with every toggle, afaict. that's what i meant with "not easily". but yes, that would be possible. hence, my comment in that patch. > if these points are not a problem @Thomas/@Stoiko, consider the pmg part > > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak >