From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D98397919C for ; Fri, 1 Jul 2022 13:36:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CE4B3912C for ; Fri, 1 Jul 2022 13:36:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 1 Jul 2022 13:36:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 770BE40B12 for ; Fri, 1 Jul 2022 13:36:15 +0200 (CEST) Message-ID: Date: Fri, 1 Jul 2022 13:36:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Thunderbird/103.0 Content-Language: en-GB To: Dominik Csapak , pmg-devel@lists.proxmox.com References: <20220701080324.1750557-1-d.csapak@proxmox.com> <7dbfea9d-6be7-ed4d-a505-6843c6f6f31e@proxmox.com> <3ac30ae3-8d45-3795-8afd-f24657f7ccd0@proxmox.com> From: Thomas Lamprecht In-Reply-To: <3ac30ae3-8d45-3795-8afd-f24657f7ccd0@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH pmg-gui v2] StatTimeSelector: don't show invalid month/day combinations X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 11:36:26 -0000 On 01/07/2022 11:57, Dominik Csapak wrote: > although the comment does not fit in 100 columns here (takes up 103) > would that be still ok, or should i try to find an even shorter > sentence? argh, missed one indentation level (clocked in at 99 here).. fine with either. > > (also after looking at it again, i'd use 'lookup' instead of > 'lookupReference' since that's only an alias and much shorter) good call