From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C48F29D9C
for <pmg-devel@lists.proxmox.com>; Wed, 6 Sep 2023 11:33:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 9D8CE31DE1
for <pmg-devel@lists.proxmox.com>; Wed, 6 Sep 2023 11:33:20 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pmg-devel@lists.proxmox.com>; Wed, 6 Sep 2023 11:33:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A429442A12;
Wed, 6 Sep 2023 11:33:18 +0200 (CEST)
Message-ID: <d5b0d556-137d-4caa-8fc9-a7b555ecb8f0@proxmox.com>
Date: Wed, 6 Sep 2023 11:33:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>, pmg-devel@lists.proxmox.com
References: <20230906065537.1475193-1-m.sandoval@proxmox.com>
<7070fc25-624b-4baa-a8e3-4542b0891d5f@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <7070fc25-624b-4baa-a8e3-4542b0891d5f@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.011 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH pmg-gui v2] js/BackupConfiguration: Add
icons to tab buttons
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 06 Sep 2023 09:33:50 -0000
On 9/6/23 11:28, Thomas Lamprecht wrote:
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>> Differences from v1:
>> - Use the `fa-database` icon for local backups as suggested by Dominik
>
> where has this been suggested? I see no review on the list..
> Please keep reviews public and not in some silo, if you really want to talk
> off list it can be fine, but the summary of that discussion needs to go
> on the mailing lists, either by Dominik suggesting that or by you replying
> to v1 that it's will be replaced by a v2 due to said suggestion from Dominik.
>
> I'd find the folder icon a slightly better fit for something local, like we
> use for local storage's in the storageSchema in Proxmox VE, but no hard
> feelings from my side – just wondering why database over that..
sorry that was probably my fault :S
Maximiliano asked me off list what i liked better, and i answered without too much thinking
of it (did not notice the v1 on the list at that point yet)
after thinking about it, i agree with thomas, that the 'folder' icon is even better,
is more consistent with pve (as that uses it for local storage too)
sorry again for the confusion
>
>>
>> js/BackupConfiguration.js | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/js/BackupConfiguration.js b/js/BackupConfiguration.js
>> index e21771f..7122822 100644
>> --- a/js/BackupConfiguration.js
>> +++ b/js/BackupConfiguration.js
>> @@ -12,11 +12,13 @@ Ext.define('PMG.BackupConfiguration', {
>> itemId: 'local',
>> title: gettext('Local Backup/Restore'),
>> xtype: 'pmgBackupRestore',
>> + iconCls: 'fa fa-database',
>> },
>> {
>> itemId: 'proxmoxbackupserver',
>> title: 'Proxmox Backup Server',
>> xtype: 'pmgPBSConfig',
>> + iconCls: 'fa fa-floppy-o',
>> },
>> ],
>> });
>