From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2742E7746F for ; Tue, 27 Apr 2021 12:34:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24F7E1EE57 for ; Tue, 27 Apr 2021 12:34:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 561FC1EE48 for ; Tue, 27 Apr 2021 12:34:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 302F645907 for ; Tue, 27 Apr 2021 12:26:10 +0200 (CEST) Message-ID: Date: Tue, 27 Apr 2021 12:26:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Oguz Bektas , pmg-devel@lists.proxmox.com References: <20210426142125.1875120-1-o.bektas@proxmox.com> <20210426142125.1875120-2-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210426142125.1875120-2-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.006 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxy.host, clamav.net, conf.in, config.pm, utils.pm, freshclam.pid] Subject: Re: [pmg-devel] [PATCH pmg-api 1/2] clamav: remove deprecated SafeBrowsing X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 10:34:23 -0000 On 26.04.21 16:21, Oguz Bektas wrote: > see > https://blog.clamav.net/2021/04/are-you-still-attempting-to-download.html links tend to 404, and more important, as probably told >100 times, the why is important to actually have in the commit message. Just including a sentence that this specific DB was discontinued in 2019 due to legal reasons would be close to zero work and give some context. A short docs or wiki (whatever stoiko prefers) about how one can create their own such signature DB[0] and use it in PMG if they have access to the Google Safe Browsing service [1] would be quite probably good too. [0]: https://github.com/Cisco-Talos/clamav-safebrowsing [1]: https://safebrowsing.google.com/ > > * remove from freshclam.conf.in template > * remove from description > * default to 0 just to be sure > * if 'safebrowsing' set in pmg.conf, this is now ignored > > note about removing the option in PMG 7.0 > > Signed-off-by: Oguz Bektas > --- > src/PMG/Config.pm | 9 +++++---- > src/PMG/Utils.pm | 3 --- > src/templates/freshclam.conf.in | 3 +-- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm > index 155990b..719b451 100755 > --- a/src/PMG/Config.pm > +++ b/src/PMG/Config.pm > @@ -186,7 +186,7 @@ sub properties { > type => 'string', > }, > clamav_heuristic_score => { > - description => "Score for ClamAV heuristics (Encrypted Archives/Documents, Google Safe Browsing database, PhishingScanURLs, ...).", > + description => "Score for ClamAV heuristics (Encrypted Archives/Documents, PhishingScanURLs, ...).", > type => 'integer', > minimum => 0, > maximum => 1000, > @@ -388,10 +388,11 @@ sub properties { > minimum => 0, > default => 0, > }, > + # FIXME: remove for PMG 7.0 - https://blog.clamav.net/2021/04/are-you-still-attempting-to-download.html > safebrowsing => { > - description => "Enables support for Google Safe Browsing.", > + description => "Enables support for Google Safe Browsing. (deprecated option, will be ignored)", > type => 'boolean', > - default => 1 > + default => 0 > }, > scriptedupdates => { > description => "Enables ScriptedUpdates (incremental download of signatures)", > @@ -410,7 +411,7 @@ sub options { > maxscansize => { optional => 1 }, > dbmirror => { optional => 1 }, > maxcccount => { optional => 1 }, > - safebrowsing => { optional => 1 }, > + safebrowsing => { optional => 1 }, # FIXME: remove for PMG 7.0 > scriptedupdates => { optional => 1}, > }; > } > diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm > index 51d6c70..43a866d 100644 > --- a/src/PMG/Utils.pm > +++ b/src/PMG/Utils.pm > @@ -861,9 +861,6 @@ sub clamav_dbstat { > $filename = "/var/lib/clamav/bytecode.cvd"; > $read_cvd_info->('bytecode', $filename) if -f $filename; > > - $filename = "/var/lib/clamav/safebrowsing.cvd"; > - $read_cvd_info->('safebrowsing', $filename) if -f $filename; > - > my $ss_dbs_fn = "/var/lib/clamav-unofficial-sigs/configs/ss-include-dbs.txt"; > my $ss_dbs_files = {}; > if (my $ssfh = IO::File->new("<${ss_dbs_fn}")) { > diff --git a/src/templates/freshclam.conf.in b/src/templates/freshclam.conf.in > index b915511..03a19d4 100644 > --- a/src/templates/freshclam.conf.in > +++ b/src/templates/freshclam.conf.in > @@ -6,7 +6,7 @@ LogFileMaxSize 0 > Foreground false > Debug false > MaxAttempts 5 > -Checks [% IF pmg.clamav.safebrowsing %]48[% ELSE %]24[% END %] > +Checks 24 > DatabaseDirectory /var/lib/clamav/ > PidFile /var/run/clamav/freshclam.pid > DatabaseMirror [% pmg.clamav.dbmirror %] > @@ -15,7 +15,6 @@ ScriptedUpdates [% IF pmg.clamav.scriptedupdates %]true[% ELSE %]false[% END %] > CompressLocalDatabase no > NotifyClamd /etc/clamav/clamd.conf > Bytecode true > -SafeBrowsing [% IF pmg.clamav.safebrowsing %]true[% ELSE %]false[% END %] > DNSDatabaseInfo current.cvd.clamav.net > [% IF proxy.host %] > HTTPProxyServer [% proxy.host %] >