From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 511FC947E9 for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 13:25:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E488858D for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 13:25:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 13:25:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9EE4044A88 for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 13:25:21 +0100 (CET) Message-ID: <ca701227-c360-4294-afe1-3987d7a476ca@proxmox.com> Date: Thu, 22 Feb 2024 13:25:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Mira Limbeck <m.limbeck@proxmox.com>, pmg-devel@lists.proxmox.com References: <20240220100648.44119-1-m.limbeck@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <20240220100648.44119-1-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH v3 pmg-log-tracker 1/5] rfc3339: move timezone offset compatibility code to old time parser X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 22 Feb 2024 12:25:23 -0000 Gave this series a look & spin code wise looks good imho as mentioned off-list, we could fix the issue of the endtimes' offset by adding the difference of offset of the end/start to the end cutoff iff we encounter lines in the old format (i.e. if the starttime was +1 and the endtime was +2, we have to subtract +2 - +1 = 1 from the endtime for the old log format) but that should not make too much difference in practice, as the old log format was broken anyway in some circumstances all in all i think this change is a net positive, since the time returned by the log-tracker is now the "real" unix epoch and we can drop the local timezone offset when we have the exact time (which is most of the time now for current installations) we probably should mention that the non exactly syslog format is deprecated though and can create problems/confusion in the log tracker tested with my local logs (no old format left sadly) and played around with the test cases with the old format and found no issues (how i hate handling time(zones) manually :P )