From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pmg-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C7BB21FF165 for <inbox@lore.proxmox.com>; Wed, 26 Feb 2025 08:31:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABD65C429; Wed, 26 Feb 2025 08:31:12 +0100 (CET) Message-ID: <bdf635bc-a210-4e66-a62b-a95496ecd299@proxmox.com> Date: Wed, 26 Feb 2025 08:30:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pmg-devel@lists.proxmox.com References: <20250225141652.4166377-1-d.csapak@proxmox.com> <5a8da3bf-00ad-4c1c-a917-2d084845dda7@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <5a8da3bf-00ad-4c1c-a917-2d084845dda7@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] applied: [PATCH widget-toolkit] object grid: fix onlineHelp setting from editorConfig for row editors X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com> On 2/25/25 18:12, Thomas Lamprecht wrote: > Am 25.02.25 um 15:16 schrieb Dominik Csapak: >> In our row editors helpers, we unconditionally set onlineHelp from >> 'opts.onlineHelp', even if it's undefined. >> >> Later we use 'Ext.apply' to set first the editorConfig defaults, then >> the 'rowdef.editor' settings. In javascript, the objects >> >> {} and >> { foo: undefined } >> >> are not the same, so Ext.apply overwrites the default from editorConfig >> with that from the row definition, also for undefined. >> >> This means if we have a default onlineHelp in editorConfig and none in >> the add_*_row options, we would not show it. >> >> To fix it, check if 'opts.onlineHelp' is truthy before setting it in >> the row definition. This should not happen for other options used >> from the row helper options, since those are nested >> (Ext.apply does not work recursively) >> >> This fixes a regression in pmg-gui, where we set a default onlineHelp >> for e.g. the Mail Proxy Options which would not show up anymore. >> >> Note: PMG is the only product where we used this pattern, so this >> was not visible anywhere in PVE or PBS. >> >> Fixes: 7d16f8b (object grid: allow to pass online help to row editors) >> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> >> --- >> src/grid/ObjectGrid.js | 20 +++++++++++++++----- >> 1 file changed, 15 insertions(+), 5 deletions(-) >> >> > > applied, thanks! > > we might need to start a policy for where patches for common repos should > (additionally) get send to to allow slightly simpler noticing then. > For now always adding pve-devel to cc for widget-toolkit patches might > be simple enough. makes sense to me, I actually thought about doing that, but then decided against that, since it's a pmg visible change only and I though that currently the patch would be more visible on pmg-devel anyway. But noted, widget-toolkit will get a cc on pve-devel in the future. Thanks! _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel