From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8C0EF8B532 for ; Sat, 22 Oct 2022 16:30:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 757882A76E for ; Sat, 22 Oct 2022 16:30:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 22 Oct 2022 16:30:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8F1C7448EF for ; Sat, 22 Oct 2022 16:30:14 +0200 (CEST) Message-ID: Date: Sat, 22 Oct 2022 16:30:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-GB To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20221020191500.2414-1-s.ivanov@proxmox.com> <20221020191500.2414-2-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221020191500.2414-2-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied: [PATCH pmg-gui 1/4] fix #4137: display receiver in attachment/virus quarantine X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2022 14:30:15 -0000 Am 20/10/2022 um 21:14 schrieb Stoiko Ivanov: > the attachment and virus quarantines contain all quarantined mail for > all recipients - so we should display which mail is being > delivered/deleted - mostly if a mail is sent to multiple addresses > served by the same PMG. > > Signed-off-by: Stoiko Ivanov > --- > * the naming of the sender_renderer (which actually just adds the sender > to the subject it actually renders) was adapted for the function name > Probably a different choice for both might be clearer > (sender_subject_renderer, sender_receiver_subject_renderer)?> > js/AttachmentQuarantine.js | 4 ++-- > js/Utils.js | 23 ++++++++++++++++++----- > js/VirusQuarantine.js | 4 ++-- > 3 files changed, 22 insertions(+), 9 deletions(-) > > applied, thanks! I made a follow up commit cleaning up the code a bit more, dropping passing along the metaData to the helper fn if it isn't used yet anyway (if we really get future direct users we can either just wrap it or re-add it) and transforming the render fns to arrow functions, with render_ in the prefix of the name. FWIW, I'm not sure that placing the "To" in a new line in the (previously) "Sender/Subject" column, but maybe rather just add a additional column and increase the default width of the quarantine grid in attachment/virus Q, bonus points if it's responsive for smaller (e.g., < 1600px width) windows /displays, with full hd and bigger the horizontal space is rather unused anyway. But, that said, it works OK enough as is, and it isn't affecting the user facing Quarantine, so I don't care to much; just noticed it and wanted to mention it, maybe someone has a better idea.