From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D0BBD9C71 for ; Fri, 4 Aug 2023 14:31:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D95BEC97 for ; Fri, 4 Aug 2023 14:30:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Aug 2023 14:30:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C3A4D40C5C; Fri, 4 Aug 2023 14:30:31 +0200 (CEST) Message-ID: Date: Fri, 4 Aug 2023 14:30:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Mira Limbeck , pmg-devel@lists.proxmox.com References: <20230718160101.1070267-1-m.limbeck@proxmox.com> From: Dominik Csapak In-Reply-To: <20230718160101.1070267-1-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [RFC log-tracker] rfc3339: move timezone offset compatibility code to X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2023 12:31:02 -0000 On 7/18/23 18:01, Mira Limbeck wrote: > old time format parsing code > > The compatibility code was added to the new rfc3339 code path temporarily so > that the old code path would not be changed before the PMG 8 release. > > Now move it to the old time format code to make sure the rfc3339 code path > works as expected. Since we have all the information we need (year, month, > day, hours, minutes, seconds, timezone), there's no need for a workaround in > this code path. > > The change needs to be accompanied by one in pmg-api MailTracker.pmg to > keep the time displayed in the GUI the same for the old time format, and > correct for the new rfc3339 format. > > Signed-off-by: Mira Limbeck > --- > After talking to Dominik this might be best sent as an RFC for further > discussions. As such I haven't touched the tests yet. > This change requires changing all tests, including the new rfc3339 ones. > > Any code that uses the pmg-log-tracker directly may behave differently > now, since the timestamps it outputs are different than before. > as we already talked off-list, i think we basically have 3 ways forward with this: * wait for the 9.x release and hope we don't forget to do this * make the change opt-in and reverse it with 9.x (or maybe remove the old code path then) with this, we could change it in the api now, and just leave the cli interface compatible by default * define it as a bug, so we can simply fix it, regardless if the behaviour is now different i'm either for 2 or 3, but of those either is fine with me (3 is ofc less work) any input on that @stoiko?