From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 591CBBFDF for ; Thu, 14 Sep 2023 09:00:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 31B3534F4F for ; Thu, 14 Sep 2023 09:00:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Sep 2023 09:00:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C19D34713C; Thu, 14 Sep 2023 09:00:08 +0200 (CEST) Message-ID: Date: Thu, 14 Sep 2023 09:00:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Christoph Heiss , pmg-devel@lists.proxmox.com References: <20230809100739.423147-1-c.heiss@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20230809100739.423147-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-gui] css: fix icon/text alignment in panel headers for Firefox X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2023 07:00:40 -0000 On 8/9/23 12:07, Christoph Heiss wrote: > Add `vertial-align: text-top` to all panel header icons - for the > accompanying text, this already gets set through the `.x-tab-inner` > class. > > Without this, in Firefox (116.0.1, at least) the icon and the text would > be slightly offset vertically - due to different baselines, I'd guess. > Chromium seems fine w/ and w/o the patch, no change there. > > Signed-off-by: Christoph Heiss > --- > css/ext6-pmg.css | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css > index 2f999f4..68e5b7a 100644 > --- a/css/ext6-pmg.css > +++ b/css/ext6-pmg.css > @@ -180,6 +180,10 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled { > height: initial; > } > > +.x-tab-icon-el { > + vertical-align: text-top; > +} > + > tr.x-grid-row-summary td.x-grid-cell { > border-top: 1px solid black; > font-weight: bold; i too looked at this, but i guess the exact rendering depends on the installed/used fonts, since in chrome it had no effect whatsoever and in firefox (102.15.0esr as well as 117.0.1 ) it makes it worse for me? i played a bit around with both the icon and text alignment, and did not find a setting that was good both for firefox and chrome. i think besides shipping a specific font this is not really fixable in general?