From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 9242F947A2
 for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 11:05:28 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 78E145DA7
 for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 11:05:28 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 11:05:24 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 084EF44817
 for <pmg-devel@lists.proxmox.com>; Thu, 22 Feb 2024 11:05:24 +0100 (CET)
Message-ID: <a764739b-357c-43d8-accd-ee73d1529aa0@proxmox.com>
Date: Thu, 22 Feb 2024 11:05:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Stefan Hanreich <s.hanreich@proxmox.com>,
 Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
References: <20240221210814.274027-1-s.ivanov@proxmox.com>
 <b1973b05-2767-4979-8319-28d49af681a5@proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <b1973b05-2767-4979-8319-28d49af681a5@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.019 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pmg-devel] [RFC pmg-api] database: use foreign keys for rule
 and object group attribute
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2024 10:05:28 -0000



On 2/22/24 10:47, Stefan Hanreich wrote:
> As discussed, looks good afaict - might want to add an index later for
> faster joins since postgres doesn't add them automatically for FKs. I'd
> assume the rule DB gets read quite often when processing mail but might
> still be overkill for a couple hundred rows.
> 

just fyi, the rule system only gets loaded once per smtp-filter startup
(via RuleCache) and then only when it's signaled to reload which should
only happen when the actual rule system changes

(i actually just sent a fix for the groups since writing you reminded me 
that if forgot that ^^)