From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B659571354 for ; Mon, 28 Jun 2021 15:32:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A83552BBC6 for ; Mon, 28 Jun 2021 15:31:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8ABB12BBB6 for ; Mon, 28 Jun 2021 15:31:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5C04444490 for ; Mon, 28 Jun 2021 15:31:41 +0200 (CEST) Message-ID: Date: Mon, 28 Jun 2021 15:31:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20210517140257.3449-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210517140257.3449-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.603 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied: [PATCH pmg-api] fix #2013 spamreport: remove ticket if authmode is ldap X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 13:32:12 -0000 On 17.05.21 16:02, Stoiko Ivanov wrote: > Currently the 'authmode' setting for the spamquarantine is not used > anywhere. According to documentation setting it to 'ldap' should allow > access to the quarantine only with ldap credentials. > > This patch addresses the issue by not generating a quarantineticket, > and adapting all links accordingly if the authmode is 'ldap'. > > tested by changing the authmode and running > `pmgqm send -receiver -debug 1` > > Signed-off-by: Stoiko Ivanov > --- > src/PMG/CLI/pmgqm.pm | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > applied, with Dominiks R-b, T-b tags, thanks! His comment was left unanswered though, just as a reminder: > just want to comment that this is now the opposite behaviour > of pmg <= 4 where setting authmode to ldap would not > change the template, but not accept quarantine tickets anymore > (which we should *probably* also do, since there may be > some valid tickets around; but this can be a separate patch) (no hard feelings regarding this from my side, as said, just a reminder to ensure it did not get lost, or was discussed off-list and the result of that did not made it to the list or the like)