From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.ivanov@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E192EBACF1 for <pmg-devel@lists.proxmox.com>; Fri, 15 Dec 2023 18:06:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C27FA67DA for <pmg-devel@lists.proxmox.com>; Fri, 15 Dec 2023 18:06:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Fri, 15 Dec 2023 18:06:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 824F247711 for <pmg-devel@lists.proxmox.com>; Fri, 15 Dec 2023 18:06:06 +0100 (CET) Date: Fri, 15 Dec 2023 18:06:04 +0100 From: Stoiko Ivanov <s.ivanov@proxmox.com> To: Dominik Csapak <d.csapak@proxmox.com> Cc: pmg-devel@lists.proxmox.com Message-ID: <ZXyHfI7O1PnuX3bz@rosa.proxmox.com> References: <20230630082748.1875726-1-d.csapak@proxmox.com> <ZXyCY2sdhuJznlOv@rosa.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <ZXyCY2sdhuJznlOv@rosa.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH pmg-api v2 1/2] fix #4811: rule db: test regex validity on save X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 15 Dec 2023 17:06:07 -0000 After testing this a bit more I realized that anchored regexes, don't die on '^*foo$' (the quite common case of mistaking regex for globs (especially for filenames) - the warning is printed to the journal - but I can happily store it (additionally the eval-block in the what/who_match never dies - and the 'invalid regex:' does not get printed. maybe we could improve this even further by die'ing upon a warning when saving the regex? - then the question is if we want to add the eval+warning code in the who/what_match subs at all (afaict this would only add 'invalid regex:' to the same log-line. In any case - thanks for the patch - I never took the time to find out why some invalid-regexes cause pmg-smtp-filter to exit+respawn, and some others don't ;) On Fri, Dec 15, 2023 at 05:44:19PM +0100, Stoiko Ivanov wrote: > Thanks for the patch, this definitely improves UX! > > one tiny nit in-line (I'll gladly change that upon applying directly, but > just don't want to miss anything): >..snip..