From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 973D31FF13A for ; Wed, 10 Jun 2026 18:26:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FA2E143E8; Wed, 10 Jun 2026 18:26:22 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 10 Jun 2026 18:26:19 +0200 Message-Id: To: "Stoiko Ivanov" , From: "Max R. Carrara" Subject: Re: [PATCH pmg-gui v2 4/5] fix #3657: system options: add log-tracker-base textrow X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20260609200637.904334-1-s.ivanov@proxmox.com> <20260609200637.904334-5-s.ivanov@proxmox.com> In-Reply-To: <20260609200637.904334-5-s.ivanov@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781108732953 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XQIKFCRVAJW554JCOQRVGENU347WCG3V X-Message-ID-Hash: XQIKFCRVAJW554JCOQRVGENU347WCG3V X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Jun 9, 2026 at 10:04 PM CEST, Stoiko Ivanov wrote: > the system options panel seems like the best place to set the location > of the logs. > > Signed-off-by: Stoiko Ivanov > --- > js/SystemOptions.js | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/js/SystemOptions.js b/js/SystemOptions.js > index 92dc5d0..b7d20fd 100644 > --- a/js/SystemOptions.js > +++ b/js/SystemOptions.js > @@ -91,6 +91,12 @@ Ext.define('PMG.SystemOptions', { > renderer: Ext.htmlEncode, > }); > > + me.add_text_row('log-tracker-base', gettext("Maillog base name")= , { > + deleteEmpty: true, > + defaultValue: '/var/log/syslog', > + renderer: Ext.htmlEncode, > + }); > + Even though it's kind of superfluous, perhaps the config option could be greyed out or disabled in some way if the currently logged in user isn't root@pam? Only a small thing though -- which probably depends on personal taste as well -- so no hard feelings if this stays as it is. > me.add_proxy_row('http_proxy', gettext('HTTP proxy')); > > me.add_textareafield_row('consent-text', gettext('Consent Text')= , {