From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0222C1FF146 for ; Tue, 09 Jun 2026 12:19:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CB1BDBF99; Tue, 9 Jun 2026 12:19:23 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Tue, 09 Jun 2026 12:18:49 +0200 Message-Id: To: "Stoiko Ivanov" Subject: Re: [PATCH installer 2/2] pmg: ensure clamav-daemon is enabled From: "Christoph Heiss" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0 References: <20260609100805.1631021-1-s.ivanov@proxmox.com> <20260609100805.1631021-3-s.ivanov@proxmox.com> In-Reply-To: <20260609100805.1631021-3-s.ivanov@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781000284167 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: H4AXWCZKUWPIW2FDTX7UCQ6CKA6YSITR X-Message-ID-Hash: H4AXWCZKUWPIW2FDTX7UCQ6CKA6YSITR X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pmg-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Jun 9, 2026 at 12:07 PM CEST, Stoiko Ivanov wrote: > the version currently in debian testing (and backported by us) > installs the service without enabling it, the tag named > `debian-1.4.4` otoh enables it. > with the back and forth unconditionally enabling it in our installer > seems like a robust measure. > > follows commit: > 72480b2 ("pmg: ensure clamav-freshclam is enabled") > > Signed-off-by: Stoiko Ivanov > --- > Proxmox/Install.pm | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm > index 8fd51a9..1740d13 100644 > --- a/Proxmox/Install.pm > +++ b/Proxmox/Install.pm > @@ -1438,13 +1438,18 @@ _EOD > "$targetdir/etc/systemd/system/multi-user.target.wants/c= lamav-clamonacc.service" > or $!{ENOENT} > or warn "failed to disable clamav-clamonacc.service - $!= \n"; > - # clamav-freshclam is not enabled automatically anymore in r= ecent versions - so ensure > - # it will start - see https://salsa.debian.org/clamav-team/c= lamav/-/merge_requests/7 > + # clamav daemons are not enabled automatically anymore in re= cent versions and the > + # upstream maintainers do change that part comparatively oft= en - so just ensure > + # that the services are enabled here > syscmd( > "ln -sf /lib/systemd/system/clamav-freshclam.service $ta= rgetdir/etc/systemd/system/multi-user.target.wants/clamav-freshclam.service= " > ) =3D=3D 0 > || warn "failed to enable clamav-freshclam.service - $!\= n"; > > + syscmd( > + "ln -sf /lib/systemd/system/clamav-freshclam.service $ta= rgetdir/etc/systemd/system/multi-user.target.wants/clamav-freshclam.service= " > + ) =3D=3D 0 > + || warn "failed to enable clamav-freshclam.service - $!\= n"; >>From a very quick glance, I supposed it's supposed be s/freshclam/daemon/g in this hunk?