From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EC85F1FF16B for ; Fri, 26 Sep 2025 14:05:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6AFAEED43; Fri, 26 Sep 2025 14:06:16 +0200 (CEST) Mime-Version: 1.0 Date: Fri, 26 Sep 2025 14:05:42 +0200 Message-Id: To: "Stoiko Ivanov" , From: "Max R. Carrara" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20250924180538.9281-1-s.ivanov@proxmox.com> <20250924180538.9281-4-s.ivanov@proxmox.com> In-Reply-To: <20250924180538.9281-4-s.ivanov@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758888326662 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [fetchmail.pid, proxmox.com, multi-user.target] Subject: Re: [pmg-devel] [PATCH package-rebuilds v2 1/1] fetchmail: improve shipped service file X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" On Wed Sep 24, 2025 at 8:05 PM CEST, Stoiko Ivanov wrote: > fetchmail exits with exit-code 3 if: > 'The user authentication step failed...' (see fetchmail(1)). > This also includes the case if there are no accounts configured for > fetching, e.g. if all accounts are configured with 'skip' instead of > 'poll'. In PMG you get this when temporary disaling all configured > accounts in the GUI. > > So we simply should not consider an exit of 3 as failure. > Additionally adapt the Restart value to 'on-failure' (else systemd > tries restarting 5 times and gives up) > see systemd.service(5). Would mention here that the user still has to run `systemctl restart fetchmail.service` if all fetchmail accounts were disabled and they re-enabled at least one of them again, as we don't do this automatically and only restart `fetchmail.service` when the first account is added. (Also correcting my earlier response [0] here.) > > Signed-off-by: Stoiko Ivanov > --- > pkgs/fetchmail/fetchmail-6.4.39/debian/fetchmail.service | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/pkgs/fetchmail/fetchmail-6.4.39/debian/fetchmail.service b/pkgs/fetchmail/fetchmail-6.4.39/debian/fetchmail.service > index a6e3168..b7260ac 100644 > --- a/pkgs/fetchmail/fetchmail-6.4.39/debian/fetchmail.service > +++ b/pkgs/fetchmail/fetchmail-6.4.39/debian/fetchmail.service > @@ -21,7 +21,8 @@ User=fetchmail > Type=exec > # sort $OPTIONS after "-daemon 300" to allow overwriting the interval using $OPTIONS > ExecStart=/usr/bin/fetchmail --daemon 300 $OPTIONS --nodetach -f /etc/fetchmailrc --pidfile /run/fetchmail/fetchmail.pid > -Restart=always > +SuccessExitStatus=3 > +Restart=on-failure > > [Install] > WantedBy=multi-user.target --- On a side note: Perhaps we could improve the handling for `fetchmail.service` in the future a little? For example ... - User adds first account, keeping it *disabled* - Current behavior: We set `START_DAEMON=yes` in `/etc/default/fetchmail` and restart `fetchmail.service` [1], because disabled accounts are also counted [2]. This has the consequence that `fetchmail.service` immediately exits, which the user might not notice. - Suggestion: Only do the above if the user adds an *enabled* account. - User deactivates all accounts, then re-enables at least one of them a little later - Current behavior: `fetchmail.service` will exit, because all accounts are disabled. When the user re-enables an account, `fetchmail.service` remains stopped; thus the user has to manually restart the service. - Suggestion: Note in the docs that this is something the user has to do; explain that they can do it via Administration > Services > fetchmail > Click on "Start" button or via the CLI. Any other automatic means of starting `fetchmail.service` would change the current bevhaior which might not be what (experienced) PMG admins desire. I don't think that these things are super-duper necessary or something; but thought I'd share my thoughts. Let me know what you think! [0]: https://lore.proxmox.com/pmg-devel/DD2MMUB49BFN.ZOWZTQYB9TP0@proxmox.com/ [1]: https://git.proxmox.com/?p=pmg-api.git;a=blob;f=src/PMG/Fetchmail.pm;h=3a64742059f625fe3e0306ea3c59034cedef9536;hb=refs/heads/master#l238 [2]: https://git.proxmox.com/?p=pmg-api.git;a=blob;f=src/PMG/Fetchmail.pm;h=3a64742059f625fe3e0306ea3c59034cedef9536;hb=refs/heads/master#l205 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel