From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pmg-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DBEC61FF16B for <inbox@lore.proxmox.com>; Thu, 20 Mar 2025 10:36:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D95930D1C; Thu, 20 Mar 2025 10:36:57 +0100 (CET) Date: Thu, 20 Mar 2025 10:36:24 +0100 Message-Id: <D8KZPW853GO0.3E6H7ZAY2QKNI@proxmox.com> From: "Christoph Heiss" <c.heiss@proxmox.com> To: "Markus Frank" <m.frank@proxmox.com> Mime-Version: 1.0 X-Mailer: aerc 0.20.1 References: <20250319132959.5149-1-m.frank@proxmox.com> In-Reply-To: <20250319132959.5149-1-m.frank@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api/pmg-gui v4 0/3] add default realm option and OIDC configuration panel X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> Cc: pmg-devel <pmg-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com> Tested this with a up-to-date Keycloak. Checked that upon first login of users, they get assigned the correct role - for both fixed role assignments and from a OIDC claim. Also made sure that the default realm selector works as intended - after clearing `localStorage`, the correct default realm is shown. W.r.t patch #3: Extending the `AuthEditOpenId` panel from proxmox-widget-toolkit would probably be more work than its worth, FWICS? No hard feelings from my side, looking at the required changes, just that duplicating mostly-similar code is always bit of a PITA, if it can be avoided. And there isn't any documentation about the role assignment feature yet, right? That should be done too, although a separate patch would be enough too IMO, in case you don't respin this series. Just a short explanation and mentioning the available values for the role assignment from an OIDC claim. In any case, please consider this series: Tested-by: Christoph Heiss <c.heiss@proxmox.com> Reviewed-by: Christoph Heiss <c.heiss@proxmox.com> On Wed Mar 19, 2025 at 2:29 PM CET, Markus Frank wrote: > v4: > * removed the default value of the realm field in the LoginView so that > the default realm is automatically selected. > > v3: > * Patch 1/3 and 2/3 are new and allow the user to set the default realm. > * see more v3 changes in Patch 3/3 > > > pmg-api: > > Markus Frank (1): > Auth Plugin: stop forcing the default realm to be the pmg realm > > src/PMG/Auth/Plugin.pm | 2 -- > 1 file changed, 2 deletions(-) > > > > pmg-gui: > > Markus Frank (2): > realms: enable default realm support > add OIDC configuration panel for PMG > > js/AuthEditOIDC.js | 244 +++++++++++++++++++++++++++++++++++++++++++ > js/LoginView.js | 1 - > js/Makefile | 1 + > js/UserManagement.js | 1 + > js/Utils.js | 17 +-- > 5 files changed, 257 insertions(+), 7 deletions(-) > create mode 100644 js/AuthEditOIDC.js _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel