From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2F97994792 for ; Thu, 22 Feb 2024 11:57:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 192ED6DE4 for ; Thu, 22 Feb 2024 11:57:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Feb 2024 11:57:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 46225448B0 for ; Thu, 22 Feb 2024 11:57:15 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 22 Feb 2024 11:57:14 +0100 Message-Id: From: "Stefan Sterz" To: "Dominik Csapak" , X-Mailer: aerc 0.17.0-57-g782a17dfb056 References: <20240215115859.1878868-1-d.csapak@proxmox.com> <20240215115859.1878868-2-d.csapak@proxmox.com> In-Reply-To: <20240215115859.1878868-2-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [RFC PATCH pmg-api 2/2] api: proxy user bl/wl calls to master X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2024 10:57:16 -0000 On Thu Feb 15, 2024 at 12:58 PM CET, Dominik Csapak wrote: > if we don't do that, the non-master nodes would get updated (when logged > in there), but that change would never be synced back to the master. > > So to prevent diverging configs, proxy them all to master. > > The GET calls are also proxied, because if we don't do that, the user > might wonder why his change is not visible on the GUI right away. > > Signed-off-by: Dominik Csapak > --- > Sending only as RFC, because we now loose the ability to see what the > non-master nodes actually have in their db... > this does improve the ux considerably as changes appear immediatelly. consider this: Tested-by: Stefan Sterz > src/PMG/API2/Quarantine.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PMG/API2/Quarantine.pm b/src/PMG/API2/Quarantine.pm > index a100e11..4eec64e 100644 > --- a/src/PMG/API2/Quarantine.pm > +++ b/src/PMG/API2/Quarantine.pm > @@ -229,6 +229,7 @@ __PACKAGE__->register_method ({ > name =3D> 'whitelist', > path =3D> 'whitelist', > method =3D> 'GET', > + proxyto =3D> 'master', > permissions =3D> { check =3D> [ 'admin', 'qmanager', 'audit', 'quser= '] }, > description =3D> "Show user whitelist.", > parameters =3D> { > @@ -258,6 +259,7 @@ __PACKAGE__->register_method ({ > name =3D> 'whitelist_add', > path =3D> 'whitelist', > method =3D> 'POST', > + proxyto =3D> 'master', > description =3D> "Add user whitelist entries.", > permissions =3D> { check =3D> [ 'admin', 'qmanager', 'audit', 'quser= '] }, > protected =3D> 1, > @@ -284,6 +286,7 @@ __PACKAGE__->register_method ({ > name =3D> 'whitelist_delete_base', > path =3D> 'whitelist', > method =3D> 'DELETE', > + proxyto =3D> 'master', > description =3D> "Delete user whitelist entries.", > permissions =3D> { check =3D> [ 'admin', 'qmanager', 'audit', 'quser= '] }, > protected =3D> 1, > @@ -311,6 +314,7 @@ __PACKAGE__->register_method ({ > name =3D> 'blacklist', > path =3D> 'blacklist', > method =3D> 'GET', > + proxyto =3D> 'master', > permissions =3D> { check =3D> [ 'admin', 'qmanager', 'audit', 'quser= '] }, > description =3D> "Show user blacklist.", > parameters =3D> { > @@ -340,6 +344,7 @@ __PACKAGE__->register_method ({ > name =3D> 'blacklist_add', > path =3D> 'blacklist', > method =3D> 'POST', > + proxyto =3D> 'master', > description =3D> "Add user blacklist entries.", > permissions =3D> { check =3D> [ 'admin', 'qmanager', 'audit', 'quser= '] }, > protected =3D> 1, > @@ -366,6 +371,7 @@ __PACKAGE__->register_method ({ > name =3D> 'blacklist_delete_base', > path =3D> 'blacklist', > method =3D> 'DELETE', > + proxyto =3D> 'master', > description =3D> "Delete user blacklist entries.", > permissions =3D> { check =3D> [ 'admin', 'qmanager', 'audit', 'quser= '] }, > protected =3D> 1,