From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D58A460467 for ; Tue, 17 Nov 2020 09:49:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D3996D86C for ; Tue, 17 Nov 2020 09:49:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 76C6FD85F for ; Tue, 17 Nov 2020 09:49:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4781043725 for ; Tue, 17 Nov 2020 09:49:36 +0100 (CET) To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20201116110118.7483-1-s.ivanov@proxmox.com> <20201116110118.7483-2-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: <97a4507d-6927-71f3-aeb7-1992e32a6b93@proxmox.com> Date: Tue, 17 Nov 2020 09:49:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201116110118.7483-2-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.090 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pbsclient.pm] Subject: [pmg-devel] applied: [PATCH pve-common v3 1/1] add PBSClient module X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 08:49:36 -0000 On 16.11.20 12:01, Stoiko Ivanov wrote: > PBSClient.pm contains methods for: > * handling (sensitive) config-information (passwords, encryption keys) > * creating/restoring/forgetting/listing backups > > code is mostly based on the current PBSPlugin in pve-storage > > Signed-off-by: Stoiko Ivanov > --- > src/Makefile | 1 + > src/PVE/PBSClient.pm | 305 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 306 insertions(+) > create mode 100644 src/PVE/PBSClient.pm > > applied, thanks! Added some followups, mostly smaller cleanups though: pbs: restore pxar: add required parameters explicitly in method signature pbs: code cleanup param array assembly pbs: autogen key: adapt recent changes in storage module PBS client: use our normal blessed method call style