From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <m.limbeck@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id B882E6A31C
 for <pmg-devel@lists.proxmox.com>; Fri, 26 Feb 2021 10:22:25 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id A8951D074
 for <pmg-devel@lists.proxmox.com>; Fri, 26 Feb 2021 10:22:25 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id E9231D066
 for <pmg-devel@lists.proxmox.com>; Fri, 26 Feb 2021 10:22:24 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BAE5A41C5E
 for <pmg-devel@lists.proxmox.com>; Fri, 26 Feb 2021 10:22:24 +0100 (CET)
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pmg-devel@lists.proxmox.com
References: <20210219103147.28013-1-m.limbeck@proxmox.com>
 <261ad9c6-a149-f37b-a040-525bf4d37d4e@proxmox.com>
From: Mira Limbeck <m.limbeck@proxmox.com>
Message-ID: <971b5023-4953-1ef4-2519-2f0069274e37@proxmox.com>
Date: Fri, 26 Feb 2021 10:22:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <261ad9c6-a149-f37b-a040-525bf4d37d4e@proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.638 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.349 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH log-tracker 1/3] update tests
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 26 Feb 2021 09:22:25 -0000

On 2/25/21 11:56 AM, Thomas Lamprecht wrote:
> On 19.02.21 11:31, Mira Limbeck wrote:
>> As we only have month, day and time available but not the year, we have
>> to update the tests every year.
> I'm probably just missing context but why exactly is that the case?
>
The logs only contain month, day and time of the day which we parse. We 
do this based on the current date and timezone.

So depending on the current date and the date in the logs, we either 
assume it to be in the past or in the future. This results in a 
different calculated CTIME then and the tests need to be updated 
accordingly.


Stoiko and I talked about this when I sent the patch, and we probably 
want to switch to logging the year as well with 7.0 so these test 
updates are no longer required afterwards.