From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9004881878 for ; Wed, 24 Nov 2021 18:58:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E88C23580 for ; Wed, 24 Nov 2021 18:58:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7DB8B23572 for ; Wed, 24 Nov 2021 18:58:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4EB3D46068 for ; Wed, 24 Nov 2021 18:58:28 +0100 (CET) Message-ID: <93fa4d7d-450f-4358-24a5-ec13a3993a68@proxmox.com> Date: Wed, 24 Nov 2021 18:58:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Dominik Csapak , pmg-devel@lists.proxmox.com References: <20211124144852.72471-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211124144852.72471-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied: [PATCH pmg-api] api: journal: stream the journal data to the client X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 17:58:59 -0000 On 24.11.21 15:48, Dominik Csapak wrote: > instead of accumulating the whole output of 'mini-journalreader' in > the api call (this can be quite big), use the download mechanic of the > http-server to stream the output to the client. > > we lose some error handling possibilities, but we do not have > to allocate anything here, and since perl does not free memory after > allocating[0] this is our desired behaviour. > > to keep api compatiblitiy, we need to give the journalreader the '-j' > flag to let it output json. > > also tell the http server that the encoding is gzip and pipe > the output through it. > > 0: https://perldoc.perl.org/perlfaq3#How-can-I-free-an-array-or-hash-so-my-program-shrinks? > > Signed-off-by: Dominik Csapak > --- > this is basically a 1:1 copy of the changes in pve-manager[0] > obviously needs the changes from http-server and mini-journalreader > from[1] > > 0: https://lists.proxmox.com/pipermail/pve-devel/2021-November/051072.html > 1: https://lists.proxmox.com/pipermail/pve-devel/2021-November/051070.html > > src/PMG/API2/Nodes.pm | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > applied, thanks!